PageAttributesCheck: Return boolean value directly from the selector (#…

…48336)
WordPress · Feb 23, 2023 · 6acbb4b · 6acbb4b · github-actions · Feb 23, 2023
1 parent 26e00a8
commit 6acbb4b
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/packages/editor/src/components/page-attributes/check.js b/packages/editor/src/components/page-attributes/check.js
@@ -10,15 +10,16 @@ import { store as coreStore } from '@wordpress/core-data';
 import { store as editorStore } from '../../store';
 
 export function PageAttributesCheck( { children } ) {
-	const postType = useSelect( ( select ) => {
+	const supportsPageAttributes = useSelect( ( select ) => {
 		const { getEditedPostAttribute } = select( editorStore );
 		const { getPostType } = select( coreStore );
+		const postType = getPostType( getEditedPostAttribute( 'type' ) );
 
-		return getPostType( getEditedPostAttribute( 'type' ) );
+		return !! postType?.supports?.[ 'page-attributes' ];
 	}, [] );
 
 	// Only render fields if post type supports page attributes or available templates exist.
-	if ( ! postType?.supports?.[ 'page-attributes' ] ) {
+	if ( ! supportsPageAttributes ) {
 		return null;
 	}