Skip to content

Commit

Permalink
Build: Enable TypeScript skipDefaultLibCheck (#63056)
Browse files Browse the repository at this point in the history 
Skip checking types that are bundled with TypeScript. We should
be able to trust these types, so they can be used without checking.

Many packages use the DOM types and this appeared as a hot spot when
analyzing the TypeScript build.

Adding this configuration should improve TypeScript build performance.

---

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: tyxla <tyxla@git.wordpress.org>
  • Loading branch information
@sirreal @tyxla
3 people authored Jul 2, 2024
1 parent 42e1fbd commit 6a5e8df
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions tsconfig.base.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
"emitDeclarationOnly": true,
"isolatedModules": true,

"skipDefaultLibCheck": true,

/* Strict Type-Checking Options */
"strict": true,

Expand Down

1 comment on commit 6a5e8df

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky tests detected in 6a5e8df.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9765032507
📝 Reported issues:

Please sign in to comment.