Focus explicitly (#29431)

WordPress · Mar 22, 2021 · 692b8b7 · 692b8b7
1 parent ec3677d
commit 692b8b7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/packages/block-library/src/embed/wp-embed-preview.js b/packages/block-library/src/embed/wp-embed-preview.js
@@ -11,7 +11,6 @@ export default function WpEmbedPreview( { html } ) {
 	useEffect( () => {
 		const { ownerDocument } = ref.current;
 		const { defaultView } = ownerDocument;
-		const { FocusEvent } = defaultView;
 
 		/**
 		 * Checks for WordPress embed events signaling the height change when iframe
@@ -58,8 +57,7 @@ export default function WpEmbedPreview( { html } ) {
 				return;
 			}
 
-			const focusEvent = new FocusEvent( 'focus', { bubbles: true } );
-			activeElement.dispatchEvent( focusEvent );
+			activeElement.focus();
 		}
 
 		defaultView.addEventListener( 'message', resizeWPembeds );

diff --git a/packages/components/src/focusable-iframe/index.js b/packages/components/src/focusable-iframe/index.js
@@ -4,15 +4,14 @@
 import { useEffect, useRef } from '@wordpress/element';
 import { useMergeRefs } from '@wordpress/compose';
 
-export default function FocusableIframe( { iframeRef, onFocus, ...props } ) {
+export default function FocusableIframe( { iframeRef, ...props } ) {
 	const fallbackRef = useRef();
 	const ref = useMergeRefs( [ iframeRef, fallbackRef ] );
 
 	useEffect( () => {
 		const iframe = fallbackRef.current;
 		const { ownerDocument } = iframe;
 		const { defaultView } = ownerDocument;
-		const { FocusEvent } = defaultView;
 
 		/**
 		 * Checks whether the iframe is the activeElement, inferring that it has
@@ -23,21 +22,15 @@ export default function FocusableIframe( { iframeRef, onFocus, ...props } ) {
 				return;
 			}
 
-			const focusEvent = new FocusEvent( 'focus', { bubbles: true } );
-
-			iframe.dispatchEvent( focusEvent );
-
-			if ( onFocus ) {
-				onFocus( focusEvent );
-			}
+			iframe.focus();
 		}
 
 		defaultView.addEventListener( 'blur', checkFocus );
 
 		return () => {
 			defaultView.removeEventListener( 'blur', checkFocus );
 		};
-	}, [ onFocus ] );
+	}, [] );
 
 	// Disable reason: The rendered iframe is a pass-through component,
 	// assigning props inherited from the rendering parent. It's the