Tweak tests; use o instead of l

WordPress · Oct 17, 2018 · 45b7686 · 45b7686
1 parent a1c039d
commit 45b7686
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/packages/edit-post/src/components/keyboard-shortcut-help-modal/config.js b/packages/edit-post/src/components/keyboard-shortcut-help-modal/config.js
@@ -45,7 +45,7 @@ const globalShortcuts = {
 			ariaLabel: shortcutAriaLabel.primaryShift( ',' ),
 		},
 		{
-			keyCombination: access( 'l' ),
+			keyCombination: access( 'o' ),
 			description: __( 'Open the block navigation menu.' ),
 		},
 		{

diff --git a/...es/edit-post/src/components/keyboard-shortcut-help-modal/test/__snapshots__/index.js.snap b/...es/edit-post/src/components/keyboard-shortcut-help-modal/test/__snapshots__/index.js.snap
@@ -80,7 +80,7 @@ exports[`KeyboardShortcutHelpModal should match snapshot when the modal is activ
               "+",
               "Alt",
               "+",
-              "B",
+              "O",
             ],
           },
           Object {

diff --git a/packages/editor/src/components/block-navigation/dropdown.js b/packages/editor/src/components/block-navigation/dropdown.js
@@ -25,7 +25,7 @@ function BlockNavigationDropdown() {
 					<KeyboardShortcuts
 						bindGlobal
 						shortcuts={ {
-							[ rawShortcut.access( 'l' ) ]: onToggle,
+							[ rawShortcut.access( 'o' ) ]: onToggle,
 						} }
 					/>
 					<IconButton

diff --git a/test/e2e/specs/block-hierarchy-navigation.test.js b/test/e2e/specs/block-hierarchy-navigation.test.js
@@ -11,6 +11,10 @@ import {
 	pressWithModifier,
 } from '../support/utils';
 
+async function openBlockNavigator() {
+	return pressWithModifier( ACCESS_MODIFIER_KEYS, 'o' );
+}
+
 describe( 'Navigating the block hierarchy', () => {
 	beforeEach( async () => {
 		await newPost();
@@ -55,7 +59,7 @@ describe( 'Navigating the block hierarchy', () => {
 		await page.keyboard.type( 'First column' );
 
 		// Navigate to the columns blocks using the keyboard.
-		await pressWithModifier( ACCESS_MODIFIER_KEYS, 'l' );
+		await openBlockNavigator();
 		await page.keyboard.press( 'Enter' );
 
 		// Move focus to the sidebar area.
@@ -69,7 +73,7 @@ describe( 'Navigating the block hierarchy', () => {
 		page.keyboard.press( 'ArrowRight' );
 
 		// Navigate to the last column in the columns block.
-		await pressWithModifier( ACCESS_MODIFIER_KEYS, 'l' );
+		await openBlockNavigator();
 		await pressTimes( 'Tab', 4 );
 		await page.keyboard.press( 'Enter' );
 
@@ -91,7 +95,7 @@ describe( 'Navigating the block hierarchy', () => {
 		await insertBlock( 'Image' );
 
 		// Return to first block.
-		await pressWithModifier( ACCESS_MODIFIER_KEYS, 'l' );
+		await openBlockNavigator();
 		await page.keyboard.press( 'Space' );
 
 		// Replace its content.
@@ -102,7 +106,7 @@ describe( 'Navigating the block hierarchy', () => {
 	} );
 
 	it( 'should report "No blocks created yet." when post is empty', async () => {
-		await pressWithModifier( ACCESS_MODIFIER_KEYS, 'l' );
+		await openBlockNavigator();
 
 		const blockNavigationText = await page.$eval(
 			'.editor-block-navigation__paragraph',