Skip to content

Commit

Permalink
delete openRevisions
Browse files Browse the repository at this point in the history
  • Loading branch information
@ramonjd
ramonjd committed Dec 18, 2023
1 parent 38ad1b9 commit 3b95f94
Showing 1 changed file with 3 additions and 7 deletions.
10 changes: 3 additions & 7 deletions test/e2e/specs/site-editor/user-global-styles-revisions.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ test.describe( 'Global styles revisions', () => {
await editor.saveSiteEditorEntities();

// Now there should be enough revisions to show the revisions UI.
await userGlobalStylesRevisions.openRevisions();
await this.page.getByRole( 'button', { name: 'Revisions' } ).click();

Check failure on line 52 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:29:2 › Global styles revisions › should display revisions UI when there is 1 revision 

  1) [chromium] › site-editor/user-global-styles-revisions.spec.js:29:2 › Global styles revisions › should display revisions UI when there is 1 revision 
    TypeError: Cannot read properties of undefined (reading 'page')

      50 |
      51 | 		// Now there should be enough revisions to show the revisions UI.
    > 52 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
         | 		           ^
      53 |
      54 | 		const revisionButtons = page.getByRole( 'button', {
      55 | 			name: /^Changes saved by /,

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:52:14

Check failure on line 52 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:29:2 › Global styles revisions › should display revisions UI when there is 1 revision 

  1) [chromium] › site-editor/user-global-styles-revisions.spec.js:29:2 › Global styles revisions › should display revisions UI when there is 1 revision 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'page')

      50 |
      51 | 		// Now there should be enough revisions to show the revisions UI.
    > 52 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
         | 		           ^
      53 |
      54 | 		const revisionButtons = page.getByRole( 'button', {
      55 | 			name: /^Changes saved by /,

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:52:14

Check failure on line 52 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:29:2 › Global styles revisions › should display revisions UI when there is 1 revision 

  1) [chromium] › site-editor/user-global-styles-revisions.spec.js:29:2 › Global styles revisions › should display revisions UI when there is 1 revision 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'page')

      50 |
      51 | 		// Now there should be enough revisions to show the revisions UI.
    > 52 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
         | 		           ^
      53 |
      54 | 		const revisionButtons = page.getByRole( 'button', {
      55 | 			name: /^Changes saved by /,

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:52:14

const revisionButtons = page.getByRole( 'button', {
name: /^Changes saved by /,
Expand Down Expand Up @@ -81,7 +81,7 @@ test.describe( 'Global styles revisions', () => {
.getByRole( 'option', { name: 'Color: Luminous vivid amber' } )
.click( { force: true } );

await userGlobalStylesRevisions.openRevisions();
await this.page.getByRole( 'button', { name: 'Revisions' } ).click();

Check failure on line 84 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:69:2 › Global styles revisions › should warn of unsaved changes before loading reset revision 

  2) [chromium] › site-editor/user-global-styles-revisions.spec.js:69:2 › Global styles revisions › should warn of unsaved changes before loading reset revision 
    TypeError: Cannot read properties of undefined (reading 'page')

      82 | 			.click( { force: true } );
      83 |
    > 84 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
         | 		           ^
      85 |
      86 | 		const unSavedButton = page.getByRole( 'button', {
      87 | 			name: /^Unsaved changes/,

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:84:14

Check failure on line 84 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:69:2 › Global styles revisions › should warn of unsaved changes before loading reset revision 

  2) [chromium] › site-editor/user-global-styles-revisions.spec.js:69:2 › Global styles revisions › should warn of unsaved changes before loading reset revision 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'page')

      82 | 			.click( { force: true } );
      83 |
    > 84 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
         | 		           ^
      85 |
      86 | 		const unSavedButton = page.getByRole( 'button', {
      87 | 			name: /^Unsaved changes/,

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:84:14

Check failure on line 84 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:69:2 › Global styles revisions › should warn of unsaved changes before loading reset revision 

  2) [chromium] › site-editor/user-global-styles-revisions.spec.js:69:2 › Global styles revisions › should warn of unsaved changes before loading reset revision 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'page')

      82 | 			.click( { force: true } );
      83 |
    > 84 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
         | 		           ^
      85 |
      86 | 		const unSavedButton = page.getByRole( 'button', {
      87 | 			name: /^Unsaved changes/,

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:84:14

const unSavedButton = page.getByRole( 'button', {
name: /^Unsaved changes/,
Expand Down Expand Up @@ -117,7 +117,7 @@ test.describe( 'Global styles revisions', () => {
} ) => {
await editor.canvas.locator( 'body' ).click();
await userGlobalStylesRevisions.openStylesPanel();
await userGlobalStylesRevisions.openRevisions();
await this.page.getByRole( 'button', { name: 'Revisions' } ).click();

Check failure on line 120 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:113:2 › Global styles revisions › should have a reset to defaults button 

  3) [chromium] › site-editor/user-global-styles-revisions.spec.js:113:2 › Global styles revisions › should have a reset to defaults button 
    TypeError: Cannot read properties of undefined (reading 'page')

      118 | 		await editor.canvas.locator( 'body' ).click();
      119 | 		await userGlobalStylesRevisions.openStylesPanel();
    > 120 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
          | 		           ^
      121 | 		const lastRevisionButton = page
      122 | 			.getByLabel( 'Global styles revisions' )
      123 | 			.getByRole( 'button' )

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:120:14

Check failure on line 120 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:113:2 › Global styles revisions › should have a reset to defaults button 

  3) [chromium] › site-editor/user-global-styles-revisions.spec.js:113:2 › Global styles revisions › should have a reset to defaults button 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'page')

      118 | 		await editor.canvas.locator( 'body' ).click();
      119 | 		await userGlobalStylesRevisions.openStylesPanel();
    > 120 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
          | 		           ^
      121 | 		const lastRevisionButton = page
      122 | 			.getByLabel( 'Global styles revisions' )
      123 | 			.getByRole( 'button' )

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:120:14

Check failure on line 120 in test/e2e/specs/site-editor/user-global-styles-revisions.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › site-editor/user-global-styles-revisions.spec.js:113:2 › Global styles revisions › should have a reset to defaults button 

  3) [chromium] › site-editor/user-global-styles-revisions.spec.js:113:2 › Global styles revisions › should have a reset to defaults button 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    TypeError: Cannot read properties of undefined (reading 'page')

      118 | 		await editor.canvas.locator( 'body' ).click();
      119 | 		await userGlobalStylesRevisions.openStylesPanel();
    > 120 | 		await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
          | 		           ^
      121 | 		const lastRevisionButton = page
      122 | 			.getByLabel( 'Global styles revisions' )
      123 | 			.getByRole( 'button' )

        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/user-global-styles-revisions.spec.js:120:14
const lastRevisionButton = page
.getByLabel( 'Global styles revisions' )
.getByRole( 'button' )
Expand Down Expand Up @@ -147,10 +147,6 @@ class UserGlobalStylesRevisions {
return [];
}

async openRevisions() {
await this.page.getByRole( 'button', { name: 'Revisions' } ).click();
}

async openStylesPanel() {
await this.page
.getByRole( 'region', { name: 'Editor top bar' } )
Expand Down

0 comments on commit 3b95f94

Please sign in to comment.