Fix: Allow px units in line-height values for the `declaration-pr…

…operty-unit-whitelist` rule. (#140)
WordPress · May 31, 2020 · 3674231 · 3674231
1 parent 5d0ad4d
commit 3674231
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/packages/stylelint-config-wordpress/CHANGELOG.md b/packages/stylelint-config-wordpress/CHANGELOG.md
@@ -1,6 +1,6 @@
 # HEAD
 
--   Added: `declaration-property-unit-whitelist` rule to enforce unitless `line-height` values.
+-   Added: `declaration-property-unit-whitelist` rule to allow `px` and exclude `%` and `em` units  in `line-height` values.
 -   Changed: Relocated repo to https://github.com/WordPress-Coding-Standards.
 -   Fixed: Include CSS config `at-rule-empty-line-before` rules in SCSS config.
 

diff --git a/packages/stylelint-config-wordpress/__tests__/values-valid.css b/packages/stylelint-config-wordpress/__tests__/values-valid.css
@@ -2,6 +2,7 @@
 	background-image: url(images/bg.png);
 	font-family: "Helvetica Neue", sans-serif;
 	font-weight: 700;
+	line-height: 14px;
 }
 
 .class { /* Correct usage of zero values */

diff --git a/packages/stylelint-config-wordpress/index.js b/packages/stylelint-config-wordpress/index.js
@@ -34,7 +34,7 @@ module.exports = {
     "declaration-colon-space-after": "always-single-line",
     "declaration-colon-space-before": "never",
     "declaration-property-unit-whitelist": {
-      "line-height": [],
+      "line-height": ["px"],
     },
     "font-family-name-quotes": "always-where-recommended",
     "font-weight-notation": [ "numeric", {