-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use PostCSS + PostCSS plugins for style transformation (#49521)
* Use PostCSS + PostCSS plugins for style transformation. * Remove the now replaced CSS parsing code. * Use synchronous PostCSS API. * Update package-lock.json * Add basic wrapping test * Use correct postcss-prefixwrap package * Update test snapshots * Add more tests and fix type signature * Ensure that data URLs do not break the CSS transformer * Do not optional chain something that is not optional * Filter out non-CSS styles before passing the array to transformStyles --------- Co-authored-by: Luis Felipe Zaguini <luisfelipezaguini@gmail.com>
- Loading branch information
Showing
22 changed files
with
474 additions
and
1,874 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
103 changes: 103 additions & 0 deletions
103
packages/block-editor/src/utils/test/__snapshots__/transform-styles.js.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,103 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`transformStyles URL rewrite should not replace absolute paths 1`] = ` | ||
[ | ||
"h1 { background: url(/images/test.png); }", | ||
] | ||
`; | ||
|
||
exports[`transformStyles URL rewrite should not replace remote paths 1`] = ` | ||
[ | ||
"h1 { background: url(http://wp.org/images/test.png); }", | ||
] | ||
`; | ||
exports[`transformStyles URL rewrite should replace complex relative paths 1`] = ` | ||
[ | ||
"h1 { background: url(http://wp-site.local/themes/gut/images/test.png); }", | ||
] | ||
`; | ||
exports[`transformStyles URL rewrite should rewrite relative paths 1`] = ` | ||
[ | ||
"h1 { background: url(http://wp-site.local/themes/gut/css/images/test.png); }", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should ignore font-face selectors 1`] = ` | ||
[ | ||
" | ||
@font-face { | ||
font-family: myFirstFont; | ||
src: url(sansation_light.woff); | ||
}", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should ignore keyframes 1`] = ` | ||
[ | ||
" | ||
@keyframes edit-post__fade-in-animation { | ||
from { | ||
opacity: 0; | ||
} | ||
}", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should ignore selectors 1`] = ` | ||
[ | ||
".my-namespace h1, body { color: red; }", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should not double wrap selectors 1`] = ` | ||
[ | ||
" .my-namespace h1, .my-namespace .red { color: red; }", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should replace :root selectors 1`] = ` | ||
[ | ||
" | ||
.my-namespace { | ||
--my-color: #ff0000; | ||
}", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should replace root tags 1`] = ` | ||
[ | ||
".my-namespace, .my-namespace h1 { color: red; }", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should wrap multiple selectors 1`] = ` | ||
[ | ||
".my-namespace h1, .my-namespace h2 { color: red; }", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should wrap regular selectors 1`] = ` | ||
[ | ||
".my-namespace h1 { color: red; }", | ||
] | ||
`; | ||
exports[`transformStyles selector wrap should wrap selectors inside container queries 1`] = ` | ||
[ | ||
" | ||
@container (width > 400px) { | ||
.my-namespace h1 { color: red; } | ||
}", | ||
] | ||
`; | ||
exports[`transformStyles should not break with data urls 1`] = ` | ||
[ | ||
".wp-block-group { | ||
background-image: url("data:image/svg+xml,%3Csvg%3E.b%7Bclip-path:url(test);%7D%3C/svg%3E"); | ||
color: red !important; | ||
}", | ||
] | ||
`; |
Oops, something went wrong.
33fabf5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in 33fabf5.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6591098997
📝 Reported issues:
specs/editor/various/pattern-blocks.test.js
specs/editor/various/pattern-blocks.test.js
specs/editor/various/pattern-blocks.test.js
specs/editor/various/pattern-blocks.test.js