WritingFlow: Avoid function instantiation in render (#3153)

WordPress · Oct 25, 2017 · 31e5867 · 31e5867
1 parent ec8df21
commit 31e5867
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/editor/writing-flow/index.js b/editor/writing-flow/index.js
@@ -8,9 +8,9 @@ import { find, reverse } from 'lodash';
  * Internal dependencies
  */
 import {
+	computeCaretRect,
 	isHorizontalEdge,
 	isVerticalEdge,
-	computeCaretRect,
 	placeCaretAtHorizontalEdge,
 	placeCaretAtVerticalEdge,
 } from '../utils/dom';
@@ -26,6 +26,7 @@ class WritingFlow extends Component {
 
 		this.onKeyDown = this.onKeyDown.bind( this );
 		this.bindContainer = this.bindContainer.bind( this );
+		this.clearVerticalRect = this.clearVerticalRect.bind( this );
 
 		this.verticalRect = null;
 	}
@@ -34,6 +35,10 @@ class WritingFlow extends Component {
 		this.container = ref;
 	}
 
+	clearVerticalRect() {
+		this.verticalRect = null;
+	}
+
 	getVisibleTabbables() {
 		return focus.tabbable
 			.find( this.container )
@@ -104,7 +109,7 @@ class WritingFlow extends Component {
 			<div
 				ref={ this.bindContainer }
 				onKeyDown={ this.onKeyDown }
-				onMouseDown={ () => this.verticalRect = null }
+				onMouseDown={ this.clearVerticalRect }
 			>
 				{ children }
 			</div>