Link format: add aria label, remove 'x' in IE (#3234)

Fixes: #2667
WordPress · Oct 31, 2017 · 31b1e14 · 31b1e14
1 parent b42dbed
commit 31b1e14
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/blocks/editable/format-toolbar/index.js b/blocks/editable/format-toolbar/index.js
@@ -185,7 +185,11 @@ class FormatToolbar extends Component {
 							<UrlInput value={ newLinkValue } onChange={ this.onChangeLinkValue } />
 							<IconButton icon="editor-break" label={ __( 'Apply' ) } type="submit" />
 							<IconButton icon="editor-unlink" label={ __( 'Remove link' ) } onClick={ this.dropLink } />
-							<IconButton icon="admin-generic" onClick={ this.toggleLinkSettingsVisibility } aria-expanded={ settingsVisible } />
+							<IconButton
+								icon="admin-generic"
+								label={ __( 'Link Settings' ) }
+								onClick={ this.toggleLinkSettingsVisibility }
+								aria-expanded={ settingsVisible } />
 							{ linkSettings }
 						</form>
 					</Fill>
@@ -203,7 +207,11 @@ class FormatToolbar extends Component {
 							</a>
 							<IconButton icon="edit" label={ __( 'Edit' ) } onClick={ this.editLink } />
 							<IconButton icon="editor-unlink" label={ __( 'Remove link' ) } onClick={ this.dropLink } />
-							<IconButton icon="admin-generic" onClick={ this.toggleLinkSettingsVisibility } aria-expanded={ settingsVisible } />
+							<IconButton
+								icon="admin-generic"
+								label={ __( 'Link Settings' ) }
+								onClick={ this.toggleLinkSettingsVisibility }
+								aria-expanded={ settingsVisible } />
 							{ linkSettings }
 						</div>
 					</Fill>

diff --git a/blocks/url-input/style.scss b/blocks/url-input/style.scss
@@ -11,6 +11,9 @@
 		border: none;
 		outline: none;
 		box-shadow: none;
+		&::-ms-clear {
+			display: none;
+		}
 	}
 
 	&:focus {