improve Tabs onSelect callback

WordPress · Nov 17, 2023 · 27f696f · 27f696f
1 parent 839acc4
commit 27f696f
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/packages/edit-post/src/components/sidebar/settings-sidebar/index.js b/packages/edit-post/src/components/sidebar/settings-sidebar/index.js
@@ -6,7 +6,7 @@ import {
 	store as blockEditorStore,
 } from '@wordpress/block-editor';
 import { useSelect, useDispatch } from '@wordpress/data';
-import { Platform, useContext } from '@wordpress/element';
+import { Platform, useCallback, useContext } from '@wordpress/element';
 import { isRTL, __ } from '@wordpress/i18n';
 import { drawerLeft, drawerRight } from '@wordpress/icons';
 import { store as interfaceStore } from '@wordpress/interface';
@@ -124,12 +124,20 @@ const SettingsSidebar = () => {
 	};
 
 	const { openGeneralSidebar } = useDispatch( editPostStore );
+
+	const onTabSelect = useCallback(
+		( newSelectedTabId ) => {
+			if ( !! newSelectedTabId ) {
+				openGeneralSidebar( newSelectedTabId );
+			}
+		},
+		[ openGeneralSidebar ]
+	);
+
 	return (
 		<Tabs
 			selectedTabId={ isSidebarOpen ? sidebarName : null }
-			onSelect={ ( selectedId ) => {
-				openGeneralSidebar( selectedId );
-			} }
+			onSelect={ onTabSelect }
 		>
 			<Content />
 		</Tabs>