Fix the multi-paragraph issue and the dangerouslySetInnerHTML

WordPress · Apr 13, 2017 · 12db3e9 · 12db3e9
1 parent 3e1e031
commit 12db3e9
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/blocks/library/quote/index.js b/blocks/library/quote/index.js
@@ -13,7 +13,9 @@ registerBlock( 'core/quote', {
 	category: 'common',
 
 	attributes: {
-		value: ( node ) => query( 'blockquote > p', html() )( node ).join(),
+		value: ( node ) => query( 'blockquote > p', html() )( node )
+			.map( innerHTML => `<p>${ innerHTML }</p>` )
+			.join( '' ),
 		citation: html( 'footer' )
 	},
 
@@ -36,15 +38,13 @@ registerBlock( 'core/quote', {
 
 	save( attributes ) {
 		const { value, citation } = attributes;
-		return (
-			<blockquote>
-				{ value }
-				{ !! citation &&
-					<footer>
-						{ citation }
-					</footer>
-				}
-			</blockquote>
-		);
+		return [
+			'<blockquote>',
+			value,
+			citation
+				? `<footer>${ citation }</footer>`
+				: '',
+			'</blockquote>'
+		].join( '' );
 	}
 } );
diff --git a/blocks/library/quote/style.scss b/blocks/library/quote/style.scss
@@ -14,7 +14,7 @@
 		margin-left: 1.3em;
 		position: relative;
 
-		&:after {
+		&:before {
 			content: '— ';
 			position: absolute;
 			left: -1.3em;