Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example block setting to show block preview #93

Merged
merged 2 commits into from
Oct 3, 2019

Conversation

mkaz
Copy link
Member

@mkaz mkaz commented Sep 20, 2019

Adds example attribute to each block with values so the block previews will show in the inserter.

Cousin PR to WordPress/gutenberg#17493 adding examples to all core blocks.

Uses Gutenberg 6.5

Adds example attribute to each block with values so the
block previews will show in the inserter.

Requires Gutenberg 6.5
mkaz added a commit to WordPress/gutenberg that referenced this pull request Sep 20, 2019
Adds example as block registration attribute
Updates tutorials with example defined in examples

Sister PR for Gutenberg Examples with same updates
WordPress/gutenberg-examples#93
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see it covered. I didn’t test so I can’t confirm it looks correct.

There are some formatting issues which only make it more prominent that we needed to add linting integration to all files and connect it with Continuous Integration.

05-recipe-card-esnext/src/index.js Outdated Show resolved Hide resolved
05-recipe-card-esnext/src/index.js Outdated Show resolved Hide resolved
01-basic/block.js Outdated Show resolved Hide resolved
mkaz added a commit to WordPress/gutenberg that referenced this pull request Sep 23, 2019
Adds example as block registration attribute
Updates tutorials with example defined in examples

Sister PR for Gutenberg Examples with same updates
WordPress/gutenberg-examples#93
@ntwb ntwb merged commit fe9c5e5 into master Oct 3, 2019
@ntwb ntwb deleted the update/add-block-preview branch October 3, 2019 00:49
@gziolo
Copy link
Member

gziolo commented Oct 3, 2019

Nice work, thank you @mkaz ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants