Update Example: Controls block to use latest API. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
reviewed
Oct 19, 2021
| "source": "children", | ||
| "selector": "p" | ||
| }, | ||
| "alignment": { |
There was a problem hiding this comment.
It would be cool to integrate Prettier formatting with this repository.
gziolo
approved these changes
Oct 19, 2021
gziolo
reviewed
Oct 19, 2021
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "extends": [ "plugin:@wordpress/eslint-plugin/es5" ], | |||
There was a problem hiding this comment.
One thing to consider (in the future) is what we discuss these days in relation to the Gutenberg project. The question is whether we should switch the split between ES5 vs ES Next + JSX to No JSX vs JSX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort in #152