Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a main tag wrapper around the query loop #726

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Add a main tag wrapper around the query loop #726

merged 1 commit into from
Sep 20, 2024

Conversation

MaggieCabrera
Copy link
Contributor

@MaggieCabrera MaggieCabrera commented Sep 20, 2024 •
edited
Loading

Closes #725

This moves the main element to a group wrapping the query loop so it works fine with zoom out mode

@MaggieCabrera MaggieCabrera self-assigned this Sep 20, 2024
getdave
getdave reviewed Sep 20, 2024
View reviewed changes
Copy link

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks solid from a Zoom Out perspective 👍

mikachan
mikachan approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mikachan mikachan merged commit fbf9933 into trunk Sep 20, 2024
2 checks passed
@mikachan mikachan deleted the add-wrapper branch September 20, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getdave getdave getdave left review comments

@mikachan mikachan mikachan approved these changes

Assignees

@MaggieCabrera MaggieCabrera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move the main tag to a wrapper instead of the query loop
3 participants
@MaggieCabrera @getdave @mikachan