Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/font management & wp-admin forms #528

Closed
wants to merge 8 commits into from
Closed

Conversation

pbking
Copy link
Contributor

@pbking pbking commented Mar 21, 2024

This change removes all of the wp-admin forms for Create Block Theme including font management and theme management.

The Sidebar tools should continue to build and work as expected.

A new "admin-landing" app has been stubbed out to replace it.

image

@creativecoder
Copy link
Contributor

I think we should get all of the options on the wp-admin form into the site editor before removing the form. It doesn't look like creating a theme variation or child theme is possible in the site editor right now. I recall seeing the child theme option used in the theme builder conversations from last year.

@pbking
Copy link
Contributor Author

pbking commented Mar 22, 2024

I think we should get all of the options on the wp-admin form into the site editor before removing the form. It doesn't look like creating a theme variation or child theme is possible in the site editor right now.

Yes, both of those features need to be in the site editor before we release. I'll get both of those features added to the list; they should both be pretty easy to add.

I don't think we need to wait to remove this code though; the admin will need to be gone before v2 ships and the features need to be in before v2 ships.

Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm don't think we should remove the current admin page without first creating the replacement. Am I missing something in terms of the benefit of doing this ahead of starting that work?

@pbking
Copy link
Contributor Author

pbking commented Apr 29, 2024

Closing this. Half of it is already in with #595 and the rest should just be done again when a replacement exists.

@pbking pbking closed this Apr 29, 2024
@vcanales vcanales deleted the remove/font-management branch May 23, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

4 participants