Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle template images into theme assets and make their urls relative #213

Merged
merged 13 commits into from
Feb 17, 2023
Merged

Bundle template images into theme assets and make their urls relative #213

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
53ed307
bundle images inserted with the editor in to the theme assets
matiasbenedetto Feb 8, 2023
86c28d0
User get_stylesheet_directory_uri() instead of get_template_direcctor…
matiasbenedetto Feb 9, 2023
0fd1b8f
making cover media local
matiasbenedetto Feb 13, 2023
b6a0abd
add support for cover blocks that use background images instead of im…
matiasbenedetto Feb 13, 2023
1fba5dc
adding support for core/media-text block
matiasbenedetto Feb 13, 2023
d9bb35b
Merge branch 'trunk' into add/bundle-images
matiasbenedetto Feb 13, 2023
5bfdf1e
escaping alt attributes of image, cover and mediatext blocks
matiasbenedetto Feb 15, 2023
614a0bb
using swith to avoid calling the functions with every block
matiasbenedetto Feb 15, 2023
c59c50e
Implementing WP_HTML_Tag_Processor to get and set element html attrib…
matiasbenedetto Feb 15, 2023
557ecce
adding theme name to translation mark
matiasbenedetto Feb 15, 2023
fe9a6cf
support to bundle video block assets
matiasbenedetto Feb 16, 2023
6f00002
Fix the template parts included in patterns
matiasbenedetto Feb 16, 2023
def9cb4
fixing theme slug in template part linked from a pattern
matiasbenedetto Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
230 changes: 217 additions & 13 deletions admin/class-create-block-theme-admin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,103 @@ function get_theme_templates( $export_type, $new_slug ) {

}

function is_absolute_url( $url ) {
return isset( parse_url( $url )[ 'host' ] );
}

function make_image_blocks_local ( $nested_blocks ) {
$new_blocks = [];
foreach ( $nested_blocks as $block ) {
// recursive call for inner blocks
if ( !empty ( $block['innerBlocks'] ) ) {
$block['innerBlocks'] = $this->make_image_blocks_local( $block[ 'innerBlocks' ] );
}
if ( 'core/image' === $block[ 'blockName' ] ) {
$doc = new DOMDocument();
@$doc->loadHTML( $block[ 'innerHTML' ], LIBXML_HTML_NOIMPLIED | LIBXML_HTML_NODEFDTD );
$tags = $doc->getElementsByTagName( 'img' );
$block_has_external_images = false;
foreach ( $tags as $tag ) {
$image_url = $tag->getAttribute( 'src' );
if ( $this->is_absolute_url( $image_url ) ) {
$block_has_external_images = true;
$media[] = $tag->getAttribute( 'src' );
$tag->setAttribute(
'src',
'<?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/'. basename( $tag->getAttribute( 'src' ) )
matiasbenedetto marked this conversation as resolved.
Show resolved Hide resolved
);
}
}
if ( $block_has_external_images ) {
$block['innerHTML'] = $doc->saveHTML();
$block['innerContent'] = array ( $doc->saveHTML() );
}
}
$new_blocks[] = $block;
}
return $new_blocks;
}

function get_media_absolute_urls_from_blocks ( $flatten_blocks ) {
$media = [];
foreach ( $flatten_blocks as $block ) {
if ('core/image' === $block[ 'blockName' ]) {
$doc = new DOMDocument();
@$doc->loadHTML( $block['innerHTML'], LIBXML_HTML_NOIMPLIED | LIBXML_HTML_NODEFDTD );
$tags = $doc->getElementsByTagName( 'img' );
$block_has_external_images = false;
foreach ($tags as $tag) {
$image_url = $tag->getAttribute( 'src' );
if ($this->is_absolute_url( $image_url )) {
$media[] = $tag->getAttribute( 'src' );
}
}
}
}
return $media;
}

// find all the media files used in the templates and add them to the zip
function make_template_images_local ( $template ) {
$new_content = $template->content;
$template_blocks = parse_blocks( $template->content );
$flatten_blocks = _flatten_blocks( $template_blocks );

$blocks = $this->make_image_blocks_local( $template_blocks );
$blocks = serialize_blocks ( $blocks );

$template->content = $this->clean_serialized_markup ( $blocks );
$template->media = $this->get_media_absolute_urls_from_blocks ( $flatten_blocks );
return $template;
}

function clean_serialized_markup ( $markup ) {
$markup = str_replace( '%20', ' ', $markup );
$markup = str_replace( '&lt;', '<', $markup );
$markup = str_replace( '&gt;', '>', $markup );
return $markup;
}

function pattern_from_template ( $template ) {
$theme_slug = wp_get_theme()->get( 'TextDomain' );
$pattern_slug = $theme_slug . '/' . $template->slug;
$pattern_content = (
'<?php
/**
* Title: '. $template->slug .'
* Slug: ' . $pattern_slug. '
* Categories: hidden
* Inserter: no
*/
?>
'. $template->content
);
return array (
'slug' => $pattern_slug,
'content' => $pattern_content
);
}

/**
* Add block templates and parts to the zip.
*
Expand All @@ -567,7 +664,6 @@ function get_theme_templates( $export_type, $new_slug ) {
* all = all templates no matter what
*/
function add_templates_to_zip( $zip, $export_type, $new_slug ) {

$theme_templates = $this->get_theme_templates( $export_type, $new_slug );

if ( $theme_templates->templates ) {
Expand All @@ -579,16 +675,59 @@ function add_templates_to_zip( $zip, $export_type, $new_slug ) {
}

foreach ( $theme_templates->templates as $template ) {
$template_data = $this->make_template_images_local( $template );

// If there are images in the template, add it as a pattern
if ( count( $template_data->media ) > 0 ) {
$pattern = $this->pattern_from_template( $template_data );
$template_data->content = '<!-- wp:pattern {"slug":"'. $pattern[ 'slug' ] .'"} /-->';

// Add pattern to zip
$zip->addFromString(
'patterns/' . $template_data->slug . '.php',
$pattern[ 'content' ]
);

// Add image assets to zip
foreach ( $template_data->media as $media ) {
$download_file = file_get_contents( $media );
$zip->addFromString( 'assets/images/' . basename( $media ), $download_file );
}
}

// Add template to zip
$zip->addFromString(
'templates/' . $template->slug . '.html',
$template->content
'templates/' . $template_data->slug . '.html',
$template_data->content
);

}

foreach ( $theme_templates->parts as $template_part ) {
$template_data = $this->make_template_images_local( $template_part );

// If there are images in the template, add it as a pattern
if ( count( $template_data->media ) > 0 ) {
$pattern = $this->pattern_from_template( $template_data );
$template_data->content = '<!-- wp:pattern {"slug":"'. $pattern[ 'slug' ] .'"} /-->';

// Add pattern to zip
$zip->addFromString(
'patterns/' . $template_data->slug . '.php',
$pattern[ 'content' ]
);

// Add image assets to zip
foreach ( $template_data->media as $media ) {
$download_file = file_get_contents( $media );
$zip->addFromString( 'assets/images/' . basename( $media ), $download_file );
}
}

// Add template to zip
$zip->addFromString(
'parts/' . $template_part->slug . '.html',
$template_part->content
'parts/' . $template_data->slug . '.html',
$template_data->content
);
}

Expand All @@ -601,27 +740,92 @@ function add_templates_to_local( $export_type ) {
$template_folders = get_block_theme_folders();

// If there is no templates folder, create it.
if ( ! is_dir( get_stylesheet_directory() . '/' . $template_folders['wp_template'] ) ) {
wp_mkdir_p( get_stylesheet_directory() . '/' . $template_folders['wp_template'] );
if ( ! is_dir( get_stylesheet_directory() . DIRECTORY_SEPARATOR . $template_folders['wp_template'] ) ) {
wp_mkdir_p( get_stylesheet_directory() . DIRECTORY_SEPARATOR . $template_folders['wp_template'] );
}

if ( ! is_dir( get_stylesheet_directory() . '/assets/images' ) ) {
wp_mkdir_p( get_stylesheet_directory() . '/assets/images' );
}

foreach ( $theme_templates->templates as $template ) {
$template_data = $this->make_template_images_local( $template );

// If there are images in the template, add it as a pattern
if ( ! empty ( $template_data->media ) ) {
// If there is no templates folder, create it.
if ( ! is_dir( get_stylesheet_directory() . DIRECTORY_SEPARATOR . 'patterns' ) ) {
wp_mkdir_p( get_stylesheet_directory() . DIRECTORY_SEPARATOR . 'patterns' );
}

// If there are external images, add it as a pattern
$pattern = $this->pattern_from_template( $template_data );
$template_data->content = '<!-- wp:pattern {"slug":"'. $pattern[ 'slug' ] .'"} /-->';

// Write the pattern
file_put_contents(
get_stylesheet_directory() . DIRECTORY_SEPARATOR . 'patterns' . DIRECTORY_SEPARATOR . $template_data->slug . '.php',
$pattern[ 'content' ]
);
}

// Write the template content
file_put_contents(
get_stylesheet_directory() . '/' . $template_folders['wp_template'] . '/' . $template->slug . '.html',
$template->content
get_stylesheet_directory() . DIRECTORY_SEPARATOR . $template_folders['wp_template'] . DIRECTORY_SEPARATOR . $template->slug . '.html',
$template_data->content
);

// Write the image assets
foreach ( $template_data->media as $media ) {
$download_file = file_get_contents( $media );
file_put_contents(
get_stylesheet_directory() . DIRECTORY_SEPARATOR .'assets' . DIRECTORY_SEPARATOR . 'images' . DIRECTORY_SEPARATOR . basename( $media ),
$download_file
);
}

}

// If there is no parts folder, create it.
if ( ! is_dir( get_stylesheet_directory() . '/' . $template_folders['wp_template_part'] ) ) {
wp_mkdir_p( get_stylesheet_directory() . '/' . $template_folders['wp_template_part'] );
if ( ! is_dir( get_stylesheet_directory() . DIRECTORY_SEPARATOR . $template_folders['wp_template_part'] ) ) {
wp_mkdir_p( get_stylesheet_directory() . DIRECTORY_SEPARATOR . $template_folders['wp_template_part'] );
}

foreach ( $theme_templates->parts as $template_part ) {
$template_data = $this->make_template_images_local( $template_part );

// If there are images in the template, add it as a pattern
if ( ! empty ( $template_data->media ) ) {
// If there is no templates folder, create it.
if ( ! is_dir( get_stylesheet_directory() . DIRECTORY_SEPARATOR . 'patterns' ) ) {
wp_mkdir_p( get_stylesheet_directory() . DIRECTORY_SEPARATOR . 'patterns' );
}

// If there are external images, add it as a pattern
$pattern = $this->pattern_from_template( $template_data );
$template_data->content = '<!-- wp:pattern {"slug":"'. $pattern[ 'slug' ] .'"} /-->';

// Write the pattern
file_put_contents(
get_stylesheet_directory() . DIRECTORY_SEPARATOR . 'patterns' . DIRECTORY_SEPARATOR . $template_data->slug . '.php',
$pattern[ 'content' ]
);
}

// Write the template content
file_put_contents(
get_stylesheet_directory() . '/' . $template_folders['wp_template_part'] . '/' . $template_part->slug . '.html',
$template_part->content
get_stylesheet_directory() . DIRECTORY_SEPARATOR . $template_folders['wp_template_part'] . DIRECTORY_SEPARATOR . $template_data->slug . '.html',
$template_data->content
);

// Write the image assets
foreach ( $template_data->media as $media ) {
$download_file = file_get_contents( $media );
file_put_contents(
get_stylesheet_directory() . DIRECTORY_SEPARATOR .'assets' . DIRECTORY_SEPARATOR . 'images' . DIRECTORY_SEPARATOR . basename( $media ),
$download_file
);
}
}
}

Expand Down