Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

Composer support #51

Merged
merged 2 commits into from
Oct 8, 2016
Merged

Composer support #51

merged 2 commits into from
Oct 8, 2016

Conversation

pelmered
Copy link
Contributor

No description provided.

@pelmered pelmered changed the title Added composer support Composer support Aug 30, 2016
@georgestephanis
Copy link
Collaborator

I'm torn on this. On one hand, I'd ordinarily be fine adding Composer support to a plugin. I merged a pull request a while back to add it to Jetpack. On the other hand, the target of this plugin is for merge into core, and doing stuff to improve it as a plugin could be counterproductive or at least diversionary to that goal. I'm going to need to think on it.

@pelmered
Copy link
Contributor Author

pelmered commented Oct 8, 2016

I can see why this is unwanted and unnecessary in the long run, but I don't really se the problem with adding this now to be honest. The composer support is completely separate from the plugin as the only file that is affected is composer.json. When the plugin should be merged you can just remove the file and there is no harm done. Nothing else in the plugin will be affected by this.

Until the merge, this helps anyone who uses composer to manage plugins. It will make the plugin more available and probably tested by more people. They would also get a good mechanism for getting newer versions of this plugin until till the plugin is merged.

@georgestephanis
Copy link
Collaborator

Fair enough. Merging.

@georgestephanis georgestephanis merged commit c975c31 into WordPress:master Oct 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants