WP/EnqueuedResources: bring back try/catch #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit dec9d40, which was part of PR 2176 removed this `try/catch` and while it shouldn't be needed anymore for valid code, it _could_ still be needed for code containing parse errors. This commit doesn't completely revert the previous commit, but does bring the try/catch back to prevent this situation. Includes unit test safeguarding the fix.
dingo-d
approved these changes
May 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit dec9d40, which was part of PR #2176 removed this
try/catchand while it shouldn't be needed anymore for valid code, it could still be needed for code containing parse errors.This commit doesn't completely revert the previous commit, but does bring the try/catch back to prevent this situation.
Includes unit test safeguarding the fix.
Related to #2243