Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - small design changes on questions and radio #2353

Open
unprintedch opened this issue Mar 28, 2024 · 3 comments
Open

Feedback - small design changes on questions and radio #2353

unprintedch opened this issue Mar 28, 2024 · 3 comments
Assignees
Labels
[Component] Sensei Website development issues related to the Sensei plugin installed on Learn. [Dev] Has PR Website related issue that also has a related pull request. [Dev] In Progress Website development issue actively being worked on.

Comments

@unprintedch
Copy link

I have noticed some small adjustements that can be made to the "learn website"

Type of feedback

Description

Learn – bug reporting

In my local versions i have some small bugs to report

The number are doubled and the radio looks broken
Capture d’écran 2024-03-28 à 12 32 10
The whole colored button has a cursor:pointer but only the is clickable.
Capture d’écran 2024-03-28 à 09 19 16

When answering a question with the reset button is in the center it feels strange
Capture d’écran 2024-03-28 à 12 21 11
Capture d’écran 2024-03-28 à 12 21 20

Radio button are not the same in every questions (quiz or not):
In a quiz associated with a lesson
Capture d’écran 2024-03-28 à 12 32 10
In a question added directy in the lesson
Capture d’écran 2024-03-28 à 12 32 23

And I think that the message box looks too similar to the button.

I would do something like this:
Capture résultat leçon 2, 28 mars 2024
Capture leçon 2, 28 mars 2024

Also added some padding and separators, but that is probably too much since they can be added in the block editor.

That are smalls things...

It is my first so feel free to correct me if i can do something better

@unprintedch unprintedch added the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Mar 28, 2024
unprintedch added a commit to unprintedch/Learn that referenced this issue Mar 28, 2024
WordPress#2353  – Some small changes to the question layout and a fix to the radio button
@unprintedch
Copy link
Author

I also made a branch in my fork with some actual fixes.
I know it is too soon since there was no triage, but i wanted to do the all process after watching the 2 great introduction workshops of @jonathanbossenger.

Here it is

I would really like feedbacks on what I have done.

@unprintedch
Copy link
Author

And I remember that there was a command to self assign the issue... But can't find it!

@digitalchild digitalchild added [Component] Sensei Website development issues related to the Sensei plugin installed on Learn. [Dev] In Progress Website development issue actively being worked on. [Dev] Has PR Website related issue that also has a related pull request. and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Mar 28, 2024
@unprintedch
Copy link
Author

unprintedch commented Mar 28, 2024

This will also fix that #2335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Sensei Website development issues related to the Sensei plugin installed on Learn. [Dev] Has PR Website related issue that also has a related pull request. [Dev] In Progress Website development issue actively being worked on.
Projects
Status: In Progress
Development

No branches or pull requests

2 participants