test: use nyc to create code coverage report #1
Conversation
also add setTimeoutAt test cases to improve code coverage
| @@ -3,11 +3,16 @@ | |||
| "version": "1.0.1", | |||
| "description": "Timers with near-infinite duration support", | |||
| "main": "index.js", | |||
| "files": [ | |||
| "index.js", | |||
| "component.json" | |||
There was a problem hiding this comment.
component.json is for GitHub installs only (it's a dead build system anyway, so perhaps it's time to remove the file altogether... but that's out of scope for this PR), so it doesn't have to be included in the NPM package.
| script: | ||
| - npm run cov | ||
| after_script: | ||
| - npm i codecov && codecov |
There was a problem hiding this comment.
Why not make codecov a dev dependency?
There was a problem hiding this comment.
Probably because it's only relevant for reporting code coverage metrics from a CI provider like Travis. Makes sense, though I would tend to still agree with you and make it a devDependency, at least for the purposes of SemVer (i.e. not ending up using an incompatible version).
|
Thanks for the contribution! I left a few small notes in-line for you. |
|
Superseded by #8 |
|
Mostly superseded by #8 but not the |
Fix setInterval should contains args and this in callback.