Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the interplay between (strong) emphasis and (inline) notes and the rendering of soft line breaks in inline notes #450

Merged
merged 17 commits into from
Jun 16, 2024
Merged

Fix the interplay between (strong) emphasis and (inline) notes and the rendering of soft line breaks in inline notes #450

merged 17 commits into from
Jun 16, 2024

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Jun 13, 2024 •
edited
Loading

This PR will make the following changes:

  • Add regression test for issue #447.
  • Fix issue #447 with the interplay between (strong) emphasis and (inline) notes.
  • Fix the rendering of soft line breaks in inline notes.
  • Update CHANGES.md.

Closes #447.

@Witiko Witiko added bug lua Related to the Lua interface and implementation conversion output Related to the output format of the Markdown-to-TeX conversion labels Jun 13, 2024
@Witiko Witiko added this to the 3.7.0 milestone Jun 13, 2024
@Witiko Witiko linked an issue Jun 13, 2024 that may be closed by this pull request
Compile error when emphasis is used both inside and outside of inline note in same paragraph #447
Closed
@Witiko Witiko force-pushed the fix/emphasis-and-notes branch from d9c8695 to 7a123e3 Compare June 13, 2024 23:37
@Witiko Witiko force-pushed the fix/emphasis-and-notes branch from 7a123e3 to 2b93a93 Compare June 13, 2024 23:43
Witiko
Witiko commented Jun 16, 2024
View reviewed changes
markdown.dtx Outdated Show resolved Hide resolved
@Witiko Witiko marked this pull request as ready for review June 16, 2024 09:57
@Witiko Witiko mentioned this pull request Jun 16, 2024
Merged
@Witiko Witiko marked this pull request as draft June 16, 2024 10:08
@Witiko Witiko marked this pull request as ready for review June 16, 2024 10:11
@Witiko
Copy link
Owner Author

Witiko commented Jun 16, 2024

Interestingly, the tests pass but the full CI is failing on the step where we typeset the documentation (make markdown.pdf):

image

The logs seem less than helpful. I try to typeset the documentation manually with the Docker image ghcr.io/witiko/markdown:3.6.0-15-g1ca9ea0e-latest-no_docs.

@Witiko Witiko force-pushed the fix/emphasis-and-notes branch from 790c9a4 to b534a0b Compare June 16, 2024 13:08
@Witiko Witiko force-pushed the fix/emphasis-and-notes branch from 71efe03 to dbd5f3c Compare June 16, 2024 13:51
Witiko added 3 commits June 16, 2024 16:45
@Witiko
Update tests for inline notes
624488c 
Test that soft line breaks are correctly rendered in inline notes.
Furthermore, remove "foot" from the "footnote" in the filenames.
@Witiko
Update CHANGES.md
480bb00
@Witiko
Test that soft line breaks are correctly rendered in inline notes
4f01fd4 
Continues commit 624488c.
@Witiko Witiko changed the title Fix the interplay between (strong) emphasis and (inline) notes Fix the interplay between (strong) emphasis and (inline) notes and the rendering of soft line breaks in inline notes Jun 16, 2024
@Witiko Witiko merged commit c279fb9 into main Jun 16, 2024
12 checks passed
@Witiko Witiko deleted the fix/emphasis-and-notes branch June 16, 2024 17:35
@Witiko Witiko mentioned this pull request Jun 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lostenderman lostenderman

Labels
bug conversion output Related to the output format of the Markdown-to-TeX conversion lua Related to the Lua interface and implementation
Projects
None yet
Milestone
3.6.1
Development

Successfully merging this pull request may close these issues.

Compile error when emphasis is used both inside and outside of inline note in same paragraph
2 participants
@Witiko @lostenderman