Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contentType Lua option #400

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Add contentType Lua option #400

merged 6 commits into from
Jan 31, 2024

Conversation

lostenderman
Copy link
Collaborator

@lostenderman lostenderman commented Jan 29, 2024 •
edited by Witiko
Loading

Continues #300.

Follows #375.

@Witiko
Copy link
Owner

Witiko commented Jan 30, 2024

Can you please rebase this PR on top of #375, so that the CI includes the test files added in #375?

Witiko
Witiko reviewed Jan 30, 2024
View reviewed changes
markdown.dtx Outdated Show resolved Hide resolved
Witiko
Witiko previously approved these changes Jan 30, 2024
View reviewed changes
markdown.dtx Outdated Show resolved Hide resolved
@Witiko Witiko marked this pull request as ready for review January 31, 2024 10:27
@Witiko Witiko added the automerge This pull request will be automatically merged after continuous integration has succeeded label Jan 31, 2024
@Witiko Witiko mentioned this pull request Jan 31, 2024
Closed
@Witiko Witiko added lua Related to the Lua interface and implementation feature request quality of life Related to quality-of-life improvements to the interface labels Jan 31, 2024
@Witiko Witiko added this to the 3.4.0 milestone Jan 31, 2024
@Witiko Witiko changed the title Add contentType option and \markinline command Add contentType Lua option Jan 31, 2024
@github-actions github-actions bot merged commit b113333 into Witiko:main Jan 31, 2024
12 checks passed
@Witiko Witiko deleted the content-type-option branch February 10, 2024 10:00
@Witiko
Copy link
Owner

Witiko commented Feb 10, 2024 •
edited
Loading

This slipped through my review but contentType should have been contentLevel. I will rename it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Witiko Witiko Witiko approved these changes

Assignees
No one assigned
Labels
automerge This pull request will be automatically merged after continuous integration has succeeded feature request lua Related to the Lua interface and implementation quality of life Related to quality-of-life improvements to the interface
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lostenderman @Witiko