Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for div and span attributes #207

Merged
merged 32 commits into from
Dec 22, 2022
Merged

Conversation

Witiko
Copy link
Owner

@Witiko Witiko commented Nov 4, 2022

Closes #126.

Tasks

  1. Port fenced divs and bracketed spans syntax extensions (see also Pandoc documentation) from jgm#36.
    1. Port fenced div and bracketed span readers.
    2. Make fenced div and bracketed span writers produce attribute context renderers.
    3. Enable the nesting of fenced divs (adapt from fix: Another attempt fixing nested fenced divs keeping structure jgm/lunamark#52).
    4. Enable fenced divs with implicit classnames and trailing colons (see Support fenced divs with implicit class names and trailing colons jgm/lunamark#59).
  2. Add fenced div and bracketed span attribute context renderers.
  3. Add blankBeforeDivFence, fencedDivs, and bracketedSpans Lua options.
  4. Load fenced divs and bracketed spans syntax extensions in M.new().
  5. Add tests
    1. Port unit tests from jgm#36 and jgm#52
      • Add testfiles/lunamark-markdown/fenced-divs.test
      • Fix the blankBeforeCodeFence option:
        The no-blank-before-code-fence.test test works, but fenced-divs.test fails.
      • Add testfiles/lunamark-markdown/no-fenced-divs.test
      • Add testfiles/lunamark-markdown/bracketed-spans.test
      • Add testfiles/lunamark-markdown/no-bracketed-spans.test
    2. Test the interplay between the fencedDivs and blankBeforeDivFence Lua options.
  6. Update CHANGES.md

@Witiko Witiko added feature request good first issue lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown labels Nov 4, 2022
@Witiko Witiko added this to the 2.19.0 milestone Nov 4, 2022
@Witiko Witiko marked this pull request as draft November 4, 2022 14:57
@Witiko Witiko force-pushed the feature/divs-and-spans branch from e113061 to 21f9d76 Compare November 4, 2022 15:58
@Witiko Witiko force-pushed the feature/divs-and-spans branch 2 times, most recently from afe1223 to 34892d0 Compare November 9, 2022 14:56
@Witiko Witiko force-pushed the feature/divs-and-spans branch from 34892d0 to f44d032 Compare November 9, 2022 15:45
@Witiko Witiko force-pushed the feature/divs-and-spans branch from a558018 to cd1c2c4 Compare November 9, 2022 15:50
@Witiko Witiko force-pushed the feature/divs-and-spans branch from 9fda969 to 514aee1 Compare November 23, 2022 15:37
@Witiko Witiko modified the milestones: 2.20.0, 2.19.0 Nov 30, 2022
@Witiko Witiko force-pushed the feature/divs-and-spans branch from 921fc87 to 71ba113 Compare December 7, 2022 20:28
Adapted from jgm#52.

Co-Authored-By: Omikhleia <didier.willis@gmail.com>
@Witiko Witiko force-pushed the feature/divs-and-spans branch from 3b7de7b to f500f21 Compare December 14, 2022 14:57
@Witiko Witiko force-pushed the feature/divs-and-spans branch 2 times, most recently from bcada75 to b9f68b8 Compare December 16, 2022 13:54
@Witiko Witiko force-pushed the feature/divs-and-spans branch 2 times, most recently from 978dd14 to 33112de Compare December 16, 2022 13:58
@Witiko Witiko force-pushed the feature/divs-and-spans branch from d03dcfb to 075a440 Compare December 20, 2022 15:26
@Witiko Witiko marked this pull request as ready for review December 22, 2022 16:04
@Witiko Witiko added the automerge This pull request will be automatically merged after continuous integration has succeeded label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge This pull request will be automatically merged after continuous integration has succeeded feature request good first issue lua Related to the Lua interface and implementation plaintex Related to the plain TeX interface and implementation syntax extension Related to syntax extensions and dialects of markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for div and span attributes
1 participant