Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax allowed timeout (GHA on macOS is slow) #1193

Merged
merged 1 commit into from
May 30, 2024
Merged

Relax allowed timeout (GHA on macOS is slow) #1193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/10.database.open.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ describe('new Database()', function () {
const start = Date.now();
expect(() => db.exec('BEGIN EXCLUSIVE')).to.throw(Database.SqliteError).with.property('code', 'SQLITE_BUSY');
const end = Date.now();
expect(end - start).to.be.within(timeout - 1, timeout * 3 + 100);
// GHA is slow: a 500ms timeout can take 1685ms to fail.
expect(end - start).to.be.within(timeout - 1, timeout * 3 + 250);
} finally {
db.close();
}
Expand Down