Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 9.4.4 misses native artifacts #1168

Closed
chgeo opened this issue Apr 3, 2024 · 4 comments
Closed

Release 9.4.4 misses native artifacts #1168

chgeo opened this issue Apr 3, 2024 · 4 comments

Comments

@chgeo
Copy link

chgeo commented Apr 3, 2024

The current 9.4.4 release only has some linux artifacts but misses Windows and Mac artifacts, because of the failing build https://github.com/WiseLibs/better-sqlite3/actions/runs/8533464864/job/23376326672.

  • Can you fix the build?
  • Is it possible to only publish to NPM after all native artifacts are available? Otherwise this makes all sorts of application builds fail.

@JoshuaWise
@chgeo chgeo mentioned this issue Apr 3, 2024
Closed
@baublet
Copy link

baublet commented Apr 3, 2024

Workaround for those who have this package locked at ^9 (or equivalent) is to lock the package version to 9.4.3. We had to do that for a deploy this morning.

@JoshuaWise
Copy link
Member

I will be looking at fixing this later today

@jlarmstrongiv
Copy link

Wow, you all are so fast! Some linux artifacts are also broken

npm ERR! prebuild-install warn install No prebuilt binaries found (target=20.11.1 runtime=node arch=x64 libc= platform=linux)

@JoshuaWise
Copy link
Member

Fixed in 9.4.5

patricebender pushed a commit to cap-js/cds-dbs that referenced this issue Apr 9, 2024
@renovate
fix(deps): update dependency better-sqlite3 to v9.4.5 (#564)
4fdad5f 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [better-sqlite3](https://togithub.com/WiseLibs/better-sqlite3) |
[`9.4.3` ->
`9.4.5`](https://renovatebot.com/diffs/npm/better-sqlite3/9.4.3/9.4.5) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/better-sqlite3/9.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/better-sqlite3/9.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/better-sqlite3/9.4.3/9.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/better-sqlite3/9.4.3/9.4.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>WiseLibs/better-sqlite3 (better-sqlite3)</summary>

###
[`v9.4.5`](https://togithub.com/WiseLibs/better-sqlite3/releases/tag/v9.4.5)

[Compare
Source](https://togithub.com/WiseLibs/better-sqlite3/compare/v9.4.4...v9.4.5)

Fixed pre-built binaries for some platforms.
([WiseLibs/better-sqlite3#1168)

**Full Changelog**:
WiseLibs/better-sqlite3@v9.4.4...v9.4.5

###
[`v9.4.4`](https://togithub.com/WiseLibs/better-sqlite3/compare/v9.4.3...080f863bfa853f87f1488a17dbee58f9265407c6)

[Compare
Source](https://togithub.com/WiseLibs/better-sqlite3/compare/v9.4.3...v9.4.4)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/cap-js/cds-dbs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@viceice viceice mentioned this issue Apr 10, 2024
Closed
1 task
@Bad3r Bad3r mentioned this issue May 17, 2024
Open
@BiraruYT BiraruYT mentioned this issue May 17, 2024
Open
@Bad3r Bad3r mentioned this issue May 22, 2024
Open
@BiraruYT BiraruYT mentioned this issue May 24, 2024
Open
@Bad3r Bad3r mentioned this issue Jun 12, 2024
Open
@Bad3r Bad3r mentioned this issue Sep 8, 2024
Open
@BiraruYT BiraruYT mentioned this issue Sep 8, 2024
Open
@jeffmartson jeffmartson mentioned this issue Sep 9, 2024
Open
@Bad3r Bad3r mentioned this issue Sep 11, 2024
Open
This was referenced Sep 13, 2024
Open
Open
This was referenced Sep 17, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@baublet @chgeo @JoshuaWise @jlarmstrongiv