Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where all files inside META-INF were skipped instead of the signature files #20

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

tapthaker
Copy link
Contributor

META-INF now contains several other entries which get skipped by the ManifestEditor. This change only skips the signature files identified by them being inside META-INF and with a particular extension.

For e.g. :

    10734  2024-10-27 06:30   META-INF/FlyDelta_deltaRelease.kotlin_module
       53  2024-10-27 06:30   META-INF/MapboxGLAndroidSDK_release.kotlin_module
    13124  2024-10-27 06:30   META-INF/SDKLICENCE.txt
       29  2024-10-27 06:30   META-INF/ShoppingHelper_release.kotlin_module
      151  2024-10-27 06:30   META-INF/activity-compose_release.kotlin_module
      180  2024-10-27 06:30   META-INF/activity-ktx_release.kotlin_module
      266  2024-10-27 06:30   META-INF/activity_release.kotlin_module
      117  2024-10-27 06:30   META-INF/airlinecomms_release.kotlin_module
        6  2024-10-27 06:30   META-INF/androidx.activity_activity-compose.version
        6  2024-10-27 06:30   META-INF/androidx.activity_activity-ktx.version
        6  2024-10-27 06:30   META-INF/androidx.activity_activity.version
        6  2024-10-27 06:30   META-INF/androidx.annotation_annotation-experimental.version
        6  2024-10-27 06:30   META-INF/androidx.appcompat_appcompat-resources.version
        6  2024-10-27 06:30   META-INF/androidx.appcompat_appcompat.version
       67  2024-10-27 06:30   META-INF/androidx.arch.core_core-runtime.version
        6  2024-10-27 06:30   META-INF/androidx.asynclayoutinflater_asynclayoutinflater.version
        6  2024-10-27 06:30   META-INF/androidx.autofill_autofill.version
        6  2024-10-27 06:30   META-INF/androidx.biometric_biometric.version
        6  2024-10-27 06:30   META-INF/androidx.browser_browser.version
        6  2024-10-27 06:30   META-INF/androidx.camera_camera-camera2.version
        6  2024-10-27 06:30   META-INF/androidx.camera_camera-core.version
        6  2024-10-27 06:30   META-INF/androidx.camera_camera-lifecycle.version
        6  2024-10-27 06:30   META-INF/androidx.camera_camera-view.version
        6  2024-10-27 06:30   META-INF/androidx.cardview_cardview.version
        6  2024-10-27 06:30   META-INF/androidx.compose.animation_animation-core.version
        6  2024-10-27 06:30   META-INF/androidx.compose.animation_animation.version
        6  2024-10-27 06:30   META-INF/androidx.compose.foundation_foundation-layout.version
        6  2024-10-27 06:30   META-INF/androidx.compose.foundation_foundation.version

@WindySha WindySha merged commit d62b314 into WindySha:master Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants