Fix sorting getting corrupted #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornut/imgui#4233 bug in imgui, sorts can return corrupted data when specs_dirty is false fixed in imgui 1.84, pyimgui is imgui 1.82 here we were always checking sort specs as different tabs can have different table ids, but switching them dont count as specs_dirty thus alway checking the actual specs allowed to sort again when changing tabs now instead we save the specs all such tables when its specs_dirty is true means no checking specs without specs_dirty, avoiding the imgui bug but can still use correct sorting when changing tab as we save different sorts for different table ids thanks FaceCrap for finding that imgui issue thread!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ocornut/imgui/issues/4233bug in imgui, sorts can return corrupted data when specs_dirty is false
fixed in imgui 1.84, pyimgui is imgui 1.82
here we were always checking sort specs as different tabs can have different table ids, but switching them dont count as specs_dirty
thus always checking the actual specs allowed to sort again when changing tabs
now instead we save the specs of all such tables when its specs_dirty is true
means no checking specs without specs_dirty, avoiding the imgui bug
but can still use correct sorting when changing tab as we save different sorts for different table ids
thanks FaceCrap for finding that imgui issue thread!