Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed show_streamer_image bug #5

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

N0thingSpecial
Copy link

Hi,
to my understanding, show_streamer_image should also show the image even if the streamer isnt live if set to true. Should be fixed with this request.

@WilliamFitzjohn
Copy link
Owner

Hey! Thanks for your MR.
Doesn't setting live_only to false give you the intended result? This should show streamers that aren't live too. Maybe I'm misunderstanding what you're trying to achieve

@N0thingSpecial
Copy link
Author

I dont think so. Its not about the complete streamer div. Its only about the image of the streamer. Before I couldnt get the image of the streamer to show when the streamer was offline (with the greyed out image) no matter what value "show_streamer_image" holds and I think this was not intended. I expected the greyed out image to show when show_streamer_image=true and the streamer is offline. Live_only is always false in this scenario.
With the changes the image also shows when the streamer is off (or on) and show_streamer_image=true. But maybe Im missunderstanding what show_streamer_image=true should do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants