Hide separator between titlebar and content

[head-gardener]

Solves #70.
Toggled via titlebar_separator enable|disable, where disable hides the border.

[WillPower3309]

Good stuff! Before I can merge this I'll have to request that you match the indentation

[head-gardener]

Thought i fixed that earlier. Should be ok now.

[WillPower3309]

LGTM! Just one more indentation fix needed

[head-gardener]

Done. Thanks for your patience.

[WillPower3309]

Thanks for all the work here! Finally have some time today to do some testing with this branch, stay tuned :)

[RicArch97]

Thanks for the implementation. For the command we could think about changing to separate_titlebar_border command as it specifically applies to the border, or perhaps titlebar_border_separator yes|no as we should make clear what this does, remove the border between the view and titlebar.

[head-gardener]

Second one seems to be more intuitive.

[WillPower3309]

Just wanted to say this will definitely get merged but I'd like to fix #96 first before making any other changes to render.c

[RicArch97]

Just tested this PR and got about half a transparent line of pixels on left side my alacritty window;

@WillPower3309 Any idea if this has something do with the other effects (shadows / rounded corners)? Can't really see how these changes would cause this.

[RicArch97]

You should probably add an entry of the new option to the man page.

I also suggest to change the option values to enable/disable instead of yes/no it's more in line with the rest of Sway's boolean options.

[head-gardener]

Any idea if this has something do with the other effects (shadows / rounded corners)? Can't really see how these changes would cause this.

This PR just prevents sway from rendering lower title bar border, so if it doesn't scale background elements correctly some areas will become empty. Issue on your screenshot is with the left pad, which I must have missed because my title textures where aligned to the left. Going to check now to see if that's the problem.

You should probably add an entry of the new option to the man page.

Honestly I've missed that we had one. Right on it.

I also suggest to change the option values to enable/disable instead of yes/no it's more in line with the rest of Sway's boolean options.

Should have done that with the last commit.

[head-gardener]

@RicArch97 can you confirm the issue is fixed?

[RicArch97]

Left a few more comments, rest LGTM

[RicArch97]

In terms of functionality it's good now. Here's an updated screenshot: