-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: blur tweaks #258
feat: blur tweaks #258
Conversation
Could you provive an image of the damage artifacts that you mentioned? Curious why I don't see them on my laptop |
recording.mp4The artifacts seem to only happen on the layer surfaces, actual windows are fine. This is also running with the recommended change for |
That's a really cool bar! What's it called? I'd like to test this and maybe make my own bar config... 😅 |
seems the artifact issue is unrelated to these changes, so marking ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, LGTM! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a ton! I'll let Will have the final say and let him merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with 2 nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff here! Just marking as request changes for those couple of nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One super nit and then LGTM :) Thanks for all the good work here!
Seems to break the blur on my system... I'll try to find the cause and post a PR @WillPower3309 |
Adds in some config commands and a shader to the blur pipeline for some tweaks:
blur_noise
(default: 0.02)blur_brightness
(default: 0.9)blur_contrast
(default: 0.9)blur_saturation
(default: 1.1)Previews:
before (noise 0, brightness 1, contrast 1, saturation 1):
after (noise 0.02, brightness 0.9, contrast 0.9, saturation 1.1)
Closes #249