Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blur tweaks #258

Merged
merged 9 commits into from
Jan 3, 2024
Merged

feat: blur tweaks #258

merged 9 commits into from
Jan 3, 2024

Conversation

ozwaldorf
Copy link
Contributor

@ozwaldorf ozwaldorf commented Dec 26, 2023

Adds in some config commands and a shader to the blur pipeline for some tweaks:

  • blur_noise (default: 0.02)
  • blur_brightness (default: 0.9)
  • blur_contrast (default: 0.9)
  • blur_saturation (default: 1.1)

Previews:

Note: open images in a new tab for full quality

before (noise 0, brightness 1, contrast 1, saturation 1):

image

after (noise 0.02, brightness 0.9, contrast 0.9, saturation 1.1)

image

Closes #249

sway/config.c Show resolved Hide resolved
sway/desktop/fx_renderer/shaders/blur3.frag Outdated Show resolved Hide resolved
sway/desktop/render.c Outdated Show resolved Hide resolved
@ErikReider
Copy link
Collaborator

Could you provive an image of the damage artifacts that you mentioned? Curious why I don't see them on my laptop

@ozwaldorf
Copy link
Contributor Author

ozwaldorf commented Dec 27, 2023

@ErikReider Could you provive an image of the damage artifacts that you mentioned? Curious why I don't see them on my laptop

recording.mp4

The artifacts seem to only happen on the layer surfaces, actual windows are fine. This is also running with the recommended change for &tempDamage -> &damage

@ErikReider
Copy link
Collaborator

@ErikReider Could you provive an image of the damage artifacts that you mentioned? Curious why I don't see them on my laptop

recording.mp4

The artifacts seem to only happen on the layer surfaces, actual windows are fine. This is also running with the recommended change for &tempDamage -> &damage

That's a really cool bar! What's it called? I'd like to test this and maybe make my own bar config... 😅

@ozwaldorf
Copy link
Contributor Author

That's a really cool bar! What's it called? I'd like to test this and maybe make my own bar config... 😅

This is ags using a mostly copy and pasted config from aylur's dots, available here

@ozwaldorf ozwaldorf marked this pull request as ready for review December 28, 2023 00:28
@ozwaldorf
Copy link
Contributor Author

seems the artifact issue is unrelated to these changes, so marking ready for review

Copy link
Collaborator

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM! :)

sway/meson.build Outdated Show resolved Hide resolved
Copy link
Collaborator

@ErikReider ErikReider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton! I'll let Will have the final say and let him merge

Copy link
Owner

@WillPower3309 WillPower3309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with 2 nits

sway/sway.5.scd Outdated Show resolved Hide resolved
sway/desktop/fx_renderer/fx_renderer.c Outdated Show resolved Hide resolved
Copy link
Owner

@WillPower3309 WillPower3309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff here! Just marking as request changes for those couple of nits

Copy link
Owner

@WillPower3309 WillPower3309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super nit and then LGTM :) Thanks for all the good work here!

README.md Outdated Show resolved Hide resolved
@WillPower3309 WillPower3309 merged commit 04b657b into WillPower3309:master Jan 3, 2024
@ErikReider
Copy link
Collaborator

Seems to break the blur on my system...

I'll try to find the cause and post a PR @WillPower3309

image

ErikReider added a commit that referenced this pull request Jan 3, 2024
ErikReider added a commit that referenced this pull request Jan 3, 2024
WillPower3309 pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blur improvements
3 participants