Add kawase blur #120

ErikReider · 2023-03-10T20:14:15Z

Fixes: #5

Todo/discussion:

Config options
Fix stencil issues with overlaying floating windows (damage tracking issue)
Code cleanup
Fix scaling issues
~~Option to ignore fully transparent windows?~~ (Can be added through a separate PR instead)
Optimization: Blur the background of tiled windows once
Add xray option like Hyprland? (only blurs once instead of for each window)
Fix blur flickering when resizing window

Investigate the dual monitor issue
Ensure that 4a8214f and db68f4a still optimally track the damage in render_blur
Ensure passing the surface scale to render_blur (as is the case now) doesn't cause breakage when using a scaled output

WillPower3309 · 2023-03-11T01:28:23Z

I suspect we wouldn't need to account for CSD with this, as it would just render in the region inside of the window

ErikReider · 2023-03-11T01:33:36Z

I suspect we wouldn't need to account for CSD with this, as it would just render in the region inside of the window

Good catch! :)

ErikReider · 2023-03-12T15:38:53Z

Sorry, tried to flick the mouse to the comment text field but accidentally clicked "close with comment"... Guess that's why I've always been stuck at DMG in CS 😅

Anyways, I found this interesting page with debugging flags. Running sway with -D damage=rerender (disabling damage tracking) fixes all artifacts. So now we just need to track down what's not working with out current damage tracking. Help would be appreciated :)

WillPower3309 · 2023-03-12T16:00:34Z

Sorry, tried to flick the mouse to the comment text field but accidentally clicked "close with comment"... Guess that's why I've always been stuck at DMG in CS 😅

Anyways, I found this interesting page with debugging flags. Running sway with -D damage=rerender (disabling damage tracking) fixes all artifacts. So now we just need to track down what's not working with out current damage tracking. Help would be appreciated :)

Great to know, good find! I can take a look on Tuesday during my flight! I'll probably have time tomorrow as well

ErikReider · 2023-03-14T14:58:13Z

Made some damage tracking fixes. Not fully fixed. Looks like it's rendering more than it needs to, creating the artifacts.

It includes the black blurred edges which is only supposed to be rendered inside of the effects buffers, and render a cropped version (the red area in the image below) into the main buffer.

sway/desktop/fx_renderer.c

ErikReider · 2023-03-15T23:16:56Z

Here's a video summary of what the damage issues are in case anyone's curious:

2023-03-16.00-06-26.mp4

WillPower3309 · 2023-03-17T17:21:48Z

As noted on our discord discussion, #127 would simplify this, and could potentially fix some of the damage tracking issues. We could even have blurred borders depending on how we implement #25 as a follow up

WillPower3309 · 2023-03-18T06:24:49Z

Question: what do you mean by blur the background of tiled windows once? Is it currently done multiple times?

ErikReider · 2023-03-18T09:34:37Z

Question: what do you mean by blur the background of tiled windows once? Is it currently done multiple times?

Before rendering we should gather a whole monitor blurred texture of what's behind the tiled windows once and use that for tiled windows instead of regathering the blur for each window (which is really expressive)

sway/desktop/fx_renderer.c

WillPower3309 · 2023-03-21T01:35:06Z

Rebased from head

WillPower3309 · 2023-03-21T04:06:54Z

Can't reproduce the issues anymore.
Edit: never mind, I definitely can, but it doesn't occur with a certain config:

config.txt

I have not been able to reproduce your damage tracking issue, if I use a config without the

corner_radius 5
smart_corner_radius on
smart_gaps on
smart_borders off
shadows on
shadows_on_csd on 
shadow_blur_radius 20
shadow_color #000000FF
gaps inner 10
default_border pixel 2

At the bottom, i just get artifacts at the bottom of the surface, visible on the window on the right:

The artifact at the top strangely only appears when I screenshot.

ErikReider · 2023-03-21T08:21:18Z

Yeah, when switching focus to a different "layer" the artifacts always appear just like when I switch focus to another window when running it inside my current sway session

WillPower3309 · 2023-03-22T00:13:47Z

Here's the commit that added blur to Hyprland: hyprwm/Hyprland@969bebb

Obviously the complexity there has increased with time, but thats the initial commit they had.

include/sway/desktop/fx_renderer.h

ErikReider · 2023-04-14T21:56:07Z

@vector1dev does it work with tiled windows/floating windows with blur_xray?

WillPower3309 · 2023-04-14T23:15:10Z

Ensure that 4a8214f and db68f4a still optimally track the damage in render_blur

Tested and it works as expected :)

Like it damages the exact same area? Just wanna make sure we're as performant as possible :)

sway/desktop/render.c

WillPower3309 · 2023-04-15T02:06:27Z

Happy to address the review comments myself, just left them in case anyone gets to it before me as my time is limited tomorrow :)

ghost · 2023-04-15T07:00:02Z

@vector1dev does it work with tiled windows/floating windows with blur_xray?

No, floating windows broken. Tiled broken too.
on first monitor - works.
on second monitor - blur don't work.

ErikReider · 2023-04-15T12:14:47Z

Like it damages the exact same area? Just wanna make sure we're as performant as possible :)

I'm guessing that you were referring to the pixman functions right?

pixman_region32_intersect_rect(&render_damage, &damage, dst_box->x, dst_box->y, dst_box->width, dst_box->height);

Should do the same thing as

pixman_region32_union_rect(&render_damage, &render_damage, dst_box.x, dst_box.y, dst_box.width, dst_box.height);
pixman_region32_intersect(&render_damage, &render_damage, damage);

~~But I might have misunderstood what the functions are doing due to the lack of pixman documentation...~~

Edit: Reading the code confirms that it's the same :)

WillPower3309 · 2023-04-15T15:18:46Z

@vector1dev does it work with tiled windows/floating windows with blur_xray?

No, floating windows broken. Tiled broken too.
on first monitor - works.
on second monitor - blur don't work.

Thanks for letting us know! Were you using the latest version of the blur branch?

ghost · 2023-04-15T16:22:01Z

@vector1dev does it work with tiled windows/floating windows with blur_xray?

No, floating windows broken. Tiled broken too.
on first monitor - works.
on second monitor - blur don't work.

Thanks for letting us know! Were you using the latest version of the blur branch?

Yes.

ErikReider

Thanks! My fever brain couldn't really figure this one out 😅

ErikReider · 2023-04-15T20:37:02Z

@vector1dev can you send a log? My guess would be that

*** BUG ***
In pixman_region32_init_rect: Invalid rectangle passed
Set a breakpoint on '_pixman_log_error' to debug

will appear.

Also, what specs are you rocking?

WillPower3309 · 2023-04-15T20:46:48Z

Also, config pls :)

ErikReider · 2023-04-15T20:50:55Z

a7d6d5e Should fix any damage integer overflow issues so you @vector1dev should try the latest commit and see if it's fixed or not :)

sway/desktop/render.c

ghost · 2023-04-16T07:26:13Z

a7d6d5e Should fix any damage integer overflow issues so you @vector1dev should try the latest commit and see if it's fixed or not :)

Fixed. Thank you!

…tor size

ErikReider · 2023-04-17T15:35:29Z

Everything should finally be ready for review! 🥳

ErikReider added the enhancement New feature or request label Mar 10, 2023

ErikReider self-assigned this Mar 10, 2023

head-gardener mentioned this pull request Mar 11, 2023

User-defined shaders #119

Draft

ErikReider closed this Mar 12, 2023

ErikReider reopened this Mar 12, 2023

WillPower3309 reviewed Mar 15, 2023

View reviewed changes

sway/desktop/fx_renderer.c Outdated Show resolved Hide resolved

WillPower3309 reviewed Mar 20, 2023

View reviewed changes

sway/desktop/fx_renderer.c Outdated Show resolved Hide resolved

WillPower3309 force-pushed the master branch from 11a4b1c to 7d5d7a3 Compare March 20, 2023 17:00

ErikReider and others added 6 commits March 20, 2023 21:26

Add kawase blur

cc5206a

Use blur for tiled windows

2918521

Added config options

c4163f0

Refactored framebuffer and stencil creation

72244a3

Significantly improved blur damage. Still not fixed though

fec171c

Minor fixes

9272552

WillPower3309 force-pushed the blur branch from 3160a5a to 9272552 Compare March 21, 2023 01:33

fix compile errors

6de7dc3

WillPower3309 reviewed Mar 22, 2023

View reviewed changes

include/sway/desktop/fx_renderer.h Outdated Show resolved Hide resolved

should_blur_draw_optimize() damage refactor

5b73ac2

WillPower3309 requested changes Apr 15, 2023

View reviewed changes

sway/desktop/render.c Outdated Show resolved Hide resolved

sway/desktop/render.c Outdated Show resolved Hide resolved

ErikReider added 2 commits April 15, 2023 16:19

Only render blur if container wants blur

1efa3f8

Extend damage if any container wants blur/shadow

ed346a5

ErikReider force-pushed the blur branch from c312474 to ed346a5 Compare April 15, 2023 14:26

Fixed not being able to toggle blur_xray during runtime

72b8274

set deco_data blur properly

8c99126

ErikReider commented Apr 15, 2023

View reviewed changes

Don't extend damaged region if larger than monitor size

a7d6d5e

WillPower3309 reviewed Apr 16, 2023

View reviewed changes

sway/desktop/render.c Outdated Show resolved Hide resolved

matching naming of other rendering functions

fcdf13c

Instead of not expanding damage if too big, limit damage size to moni…

eff5b81

…tor size

ErikReider requested a review from WillPower3309 April 17, 2023 15:34

removed wlr_box_from_pixman_region32

54d2c11

WillPower3309 approved these changes Apr 17, 2023

View reviewed changes

ErikReider merged commit cbfb7af into master Apr 17, 2023

ErikReider deleted the blur branch April 17, 2023 21:24

WillPower3309 mentioned this pull request May 7, 2023

Blur damage tracking simplification #155

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add kawase blur #120

Add kawase blur #120

ErikReider commented Mar 10, 2023 •

edited

Loading

WillPower3309 commented Mar 11, 2023

ErikReider commented Mar 11, 2023

ErikReider commented Mar 12, 2023

WillPower3309 commented Mar 12, 2023

ErikReider commented Mar 14, 2023

ErikReider commented Mar 15, 2023

WillPower3309 commented Mar 17, 2023

WillPower3309 commented Mar 18, 2023

ErikReider commented Mar 18, 2023

WillPower3309 commented Mar 21, 2023

WillPower3309 commented Mar 21, 2023 •

edited

Loading

ErikReider commented Mar 21, 2023

WillPower3309 commented Mar 22, 2023

ErikReider commented Apr 14, 2023

WillPower3309 commented Apr 14, 2023 •

edited

Loading

WillPower3309 commented Apr 15, 2023

ghost commented Apr 15, 2023 •

edited by ghost

Loading

ErikReider commented Apr 15, 2023 •

edited

Loading

WillPower3309 commented Apr 15, 2023

ghost commented Apr 15, 2023

ErikReider left a comment

ErikReider commented Apr 15, 2023 •

edited

Loading

WillPower3309 commented Apr 15, 2023

ErikReider commented Apr 15, 2023

ghost commented Apr 16, 2023

ErikReider commented Apr 17, 2023

Add kawase blur #120

Add kawase blur #120

Conversation

ErikReider commented Mar 10, 2023 • edited Loading

WillPower3309 commented Mar 11, 2023

ErikReider commented Mar 11, 2023

ErikReider commented Mar 12, 2023

WillPower3309 commented Mar 12, 2023

ErikReider commented Mar 14, 2023

ErikReider commented Mar 15, 2023

WillPower3309 commented Mar 17, 2023

WillPower3309 commented Mar 18, 2023

ErikReider commented Mar 18, 2023

WillPower3309 commented Mar 21, 2023

WillPower3309 commented Mar 21, 2023 • edited Loading

ErikReider commented Mar 21, 2023

WillPower3309 commented Mar 22, 2023

ErikReider commented Apr 14, 2023

WillPower3309 commented Apr 14, 2023 • edited Loading

WillPower3309 commented Apr 15, 2023

ghost commented Apr 15, 2023 • edited by ghost Loading

ErikReider commented Apr 15, 2023 • edited Loading

WillPower3309 commented Apr 15, 2023

ghost commented Apr 15, 2023

ErikReider left a comment

Choose a reason for hiding this comment

ErikReider commented Apr 15, 2023 • edited Loading

WillPower3309 commented Apr 15, 2023

ErikReider commented Apr 15, 2023

ghost commented Apr 16, 2023

ErikReider commented Apr 17, 2023

ErikReider commented Mar 10, 2023 •

edited

Loading

WillPower3309 commented Mar 21, 2023 •

edited

Loading

WillPower3309 commented Apr 14, 2023 •

edited

Loading

ghost commented Apr 15, 2023 •

edited by ghost

Loading

ErikReider commented Apr 15, 2023 •

edited

Loading

ErikReider commented Apr 15, 2023 •

edited

Loading