-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement for_window support for dim_inactive #109
Implement for_window support for dim_inactive #109
Conversation
I have tested this for a bit in my day to day stuff, didn't find any issues, so I am marking this as ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late review, love the work you've done here! Minor NIT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More nits, once those are addressed I think it's good to merge
Fixed some other indention issues as well, everything should be properly indented now now. |
Note: this still requires more testing, I just did some basic tests on my setup so far.
This should fix #68.