Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement for_window support for dim_inactive #109

Merged
merged 9 commits into from
Feb 15, 2023

Conversation

famfo
Copy link
Contributor

@famfo famfo commented Feb 4, 2023

Note: this still requires more testing, I just did some basic tests on my setup so far.

This should fix #68.

@famfo famfo marked this pull request as ready for review February 5, 2023 17:40
@famfo
Copy link
Contributor Author

famfo commented Feb 5, 2023

I have tested this for a bit in my day to day stuff, didn't find any issues, so I am marking this as ready for review.

Copy link
Owner

@WillPower3309 WillPower3309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review, love the work you've done here! Minor NIT

sway/meson.build Outdated Show resolved Hide resolved
Copy link
Owner

@WillPower3309 WillPower3309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More nits, once those are addressed I think it's good to merge

sway/commands.c Outdated Show resolved Hide resolved
sway/desktop/render.c Outdated Show resolved Hide resolved
sway/desktop/render.c Outdated Show resolved Hide resolved
sway/desktop/render.c Outdated Show resolved Hide resolved
sway/desktop/render.c Outdated Show resolved Hide resolved
sway/tree/container.c Outdated Show resolved Hide resolved
@famfo
Copy link
Contributor Author

famfo commented Feb 14, 2023

Fixed some other indention issues as well, everything should be properly indented now now.

@WillPower3309 WillPower3309 merged commit 9f20a52 into WillPower3309:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore dim on certain windows
3 participants