Part of window disappears on vertical monitor

[GlitchyCrafting]

Swayfx Version: 0.1-1 from AUR

Using Default Config file but with monitors arranged how I need them.

The bottom corner of any application gets removed, more of that corner disappears when multiple windows are opened and it only affects the bottom-most window. Also affects context menus in Firefox and Chrome. None of these happen on my other two monitors, only my vertical one.

Alacritty

Firefox

Multiple Windows

Chromium

PCManFM-GTK3

[ErikReider]

What resolution and scaling are you running on that monitor? Does it happen with other resolution and scaling values?

[ErikReider]

I'm experiencing the same issue. Very weird... Could you check if base sway 1.7 experiences this @GlitchyCrafting

[GlitchyCrafting]

I'm experiencing the same issue. Very weird... Could you check if base sway 1.7 experiences this @GlitchyCrafting

It does not. Actually had to go back to base Sway 'cause I use that monitor so much.

[ErikReider]

The even weirder thing about this is that I can't replicate this issue when running swayfx in nested mode (open another swayfx instance inside of swayfx), just when starting it from a tty???

Edit: I've even tried running it nested and creating a dummy output (swaymsg create_output dummy_output) and it still works while nested...

[ErikReider]

I've narrowed it down to the tex_*.frag shaders. Seems like the quad_round_*.frag shaders ara also experiencing this bug

[ErikReider]

swayfx/sway/desktop/shaders/tex_rgbx.frag

Lines 23 to 30 in 7ccabda

	if (!has_titlebar || gl_FragCoord.y - position.y > radius) {
	vec2 corner_distance = min(gl_FragCoord.xy - position, size + position - gl_FragCoord.xy);
	if (max(corner_distance.x, corner_distance.y) < radius) {
	float d = radius - distance(corner_distance, vec2(radius));
	float smooth = smoothstep(-1.0f, 0.5f, d);
	gl_FragColor = mix(vec4(0), gl_FragColor, smooth);
	}
	}

swayfx/sway/desktop/shaders/tex_rgba.frag

Lines 24 to 31 in 7ccabda

	if (!has_titlebar || gl_FragCoord.y - position.y > radius) {
	vec2 corner_distance = min(gl_FragCoord.xy - position, size + position - gl_FragCoord.xy);
	if (max(corner_distance.x, corner_distance.y) < radius) {
	float d = radius - distance(corner_distance, vec2(radius));
	float smooth = smoothstep(-1.0f, 0.5f, d);
	gl_FragColor = mix(vec4(0), gl_FragColor, smooth);
	}
	}

swayfx/sway/desktop/shaders/tex_external.frag

Lines 26 to 33 in 7ccabda

	if (!has_titlebar || gl_FragCoord.y - position.y > radius) {
	vec2 corner_distance = min(gl_FragCoord.xy - position, size + position - gl_FragCoord.xy);
	if (max(corner_distance.x, corner_distance.y) < radius) {
	float d = radius - distance(corner_distance, vec2(radius));
	float smooth = smoothstep(-1.0f, 0.5f, d);
	gl_FragColor = mix(vec4(0), gl_FragColor, smooth);
	}
	}

Seems to be the cause. Do you @WillPower3309 have any idea why this could happen?

[ErikReider]

Also seems like the rounded corners aren't visible on the vertical monitor either

[WillPower3309]

Yup, I think I know exactly what's wrong here! I'll take a look at a fix as soon as I can

[WillPower3309]

I'm experiencing the same issue. Very weird... Could you check if base sway 1.7 experiences this @GlitchyCrafting

Would you mind checking if rounded titlebars are strange too @ErikReider ? No worries if not, I can set up a vertical monitor

[ErikReider]

Would you mind checking if rounded titlebars are strange too @ErikReider ? No worries if not, I can set up a vertical monitor

I also experienced issues with the filling and the corners of the titlebar. Weird bug :/

[GlitchyCrafting]

What resolution and scaling are you running on that monitor? Does it happen with other resolution and scaling values?

Resolution: 1280x1024@75Hz
Scaling: 1.0

[frap129]

Yup, I think I know exactly what's wrong here! I'll take a look at a fix as soon as I can

Came here to report the same bug, but it sounds like you've got it handled!

[frap129]

Still having this issue on the latest release :(

[WillPower3309]

Yup, sorry to say that it has not been fixed yet. Hoping to take a look soon

[ErikReider]

Maybe the sizing isn't correct?

Also flipping the width/height and x/y seems to do something. It's at least a step in the right direction

swayfx/sway/desktop/fx_renderer.c

Lines 426 to 427 in 1baba77

	glUniform2f(shader->size, dst_box->width, dst_box->height);
	glUniform2f(shader->position, dst_box->x, dst_box->y);