Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make nodal and qp clearer #28

Open
WilkAndy opened this issue Apr 18, 2016 · 2 comments
Open

make nodal and qp clearer #28

WilkAndy opened this issue Apr 18, 2016 · 2 comments

Comments

@WilkAndy
Copy link
Owner

At the moment the Materials and Kernels use, e.g. "saturation" and "saturation_qp". The "_qp" is ok, but we should explicitly use the string "_nodal" for nodal quantities. It's clearer.

@cpgr
Copy link

cpgr commented Apr 19, 2016

I agree - I'll do this

@WilkAndy
Copy link
Owner Author

I've done a small bit. this is my convention:

_porosity_nodal(declareProperty("PorousFlow_porosity_nodal")),
_porosity_nodal_old(declarePropertyOld("PorousFlow_porosity_nodal")),
_dporosity_nodal_dvar(declarePropertystd::vector("dPorousFlow_porosity_nodal_dvar")),
_dporosity_nodal_dgradvar(declarePropertystd::vector("dPorousFlow_porosity_nodal_dgradvar")),
_porosity_qp(declareProperty("PorousFlow_porosity_qp")),
_porosity_qp_old(declarePropertyOld("PorousFlow_porosity_qp")),
_dporosity_qp_dvar(declarePropertystd::vector("dPorousFlow_porosity_qp_dvar")),
_dporosity_qp_dgradvar(declarePropertystd::vector("dPorousFlow_porosity_qp_dgradvar"))

WilkAndy added a commit that referenced this issue Apr 19, 2016
Explicitly label nodal material properties. Refers to #28
WilkAndy added a commit that referenced this issue Apr 19, 2016
Explicitly reference nodal properties in fluids. Refs #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants