-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make nodal and qp clearer #28
Comments
I agree - I'll do this |
I've done a small bit. this is my convention: _porosity_nodal(declareProperty("PorousFlow_porosity_nodal")), |
Explicitly label nodal material properties. Refers to #28
Explicitly reference nodal properties in fluids. Refs #28
At the moment the Materials and Kernels use, e.g. "saturation" and "saturation_qp". The "_qp" is ok, but we should explicitly use the string "_nodal" for nodal quantities. It's clearer.
The text was updated successfully, but these errors were encountered: