Meadow.Foundation cleanup #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patridge
approved these changes
Oct 19, 2022
| @@ -49,8 +49,6 @@ public async Task RotateTo(Angle angle, bool stopAfterMotion = false) | |||
| // wait for completion | |||
| var rotationRequired = Math.Abs((Angle.HasValue ? Angle.Value.Degrees : 360) - angle.Degrees); | |||
| var delay = (int)(8 * rotationRequired); // estimating 8ms / degree | |||
| Console.WriteLine($"Start: {Angle?.Degrees??-1} End:={angle.Degrees}"); | |||
There was a problem hiding this comment.
Did we need to replace these output lines with something else?
There was a problem hiding this comment.
No we shouldn't have console writes in the drivers at all
There was a problem hiding this comment.
Correct, we only do Console.WriteLines when working on a driver, but never should make it to the driver once its available to the public.
adrianstevens
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.