Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve deployment stage time execution + prevent loosing data in prod #141

Merged
merged 10 commits into from
Mar 16, 2024

Conversation

Gwada
Copy link

@Gwada Gwada commented Feb 1, 2024

This pull request improves the deployment steps.

  • Significantly reduced deployment time.
  • Use of a lighter docker image.
  • Docker layer management for advanced cache usage
  • Removal of volumes to boost performance and reduce consumption of hardware resources
  • Use of pnpm for installing dependencies (you know why)
  • Prevent database dropping on each deployment

@Gwada Gwada force-pushed the improve-ci branch 5 times, most recently from 8483e20 to ec65d65 Compare February 1, 2024 16:57
@Gwada Gwada requested review from jfm-wcs and rocambille February 1, 2024 17:51
@rocambille
Copy link
Collaborator

Impressive one for improvement of deployment 🚀

Prevent database dropping might cause issues during development/deployment: SQL queries should be constructed and executed very rigorously from schema.sql with alter queries to allow column additions/deletions/modifications. This might be complex to handle for students. What do you think?

@Gwada
Copy link
Author

Gwada commented Feb 10, 2024

Impressive one for improvement of deployment 🚀

Prevent database dropping might cause issues during development/deployment: SQL queries should be constructed and executed very rigorously from schema.sql with alter queries to allow column additions/deletions/modifications. This might be complex to handle for students. What do you think?

I agree with you. Managing migrations is complicated, and I think it's necessary for learners to be aware of the rigor these files require. It's good practice for their professional careers. Moreover, my learners have worked with this constraint and have not been hindered. Of course, they still have the option to delete the database if necessary, and the instructor can also do it in production via phpMyAdmin. Other solutions are also conceivable, such as using an ORM like Sequelize, which allows for better migration management.

@rocambille rocambille merged commit eeb3a89 into dev Mar 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants