Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Touch Screen support #649

Closed
mmcfarland opened this issue Jul 31, 2015 · 1 comment
Closed

Windows Touch Screen support #649

mmcfarland opened this issue Jul 31, 2015 · 1 comment
Assignees
Milestone

Comments

@mmcfarland
Copy link
Contributor

mmcfarland commented Jul 31, 2015

With work on #502 we established some parameters of devices that we were willing not to support due to problems in our L.Draw fork. A workshop user was unable to close a polygon on the draw screen using an HP Intel ProBook, which is claiming not to be a touch device, although the screengrab of the settings for that computer indicate that there is some touch support (see System -> Pen and Touch below).

img_0542

@rajadain
Copy link
Member

Just tested on a Windows touchscreen with Leaflet.Draw 0.3.0 (latest release version) and 0.3.2 (latest available tag), with not great results.

Chrome 52 still doesn't close shapes when using the mouse. Touch works correctly.
Firefox 42 closes shapes correctly using the mouse, but Touch is really flaky.
Edge and IE11 seem to be working perfectly in both cases, which is an improvement over the last version where the site wouldn't render in IE.

So for our Windows users, we should recommend Edge.

I'm going to put up a PR that upgrades to 0.3.0, the latest stable version. There is Leaflet/Leaflet.draw#548, which I've subscribed to. Unfortunately, if we want to investigate the guts of Leaflet.draw to see if this can be figured out, we'll need more points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants