Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly UI Reactions #842

Open
wants to merge 8 commits into
base: ui_refactor
Choose a base branch
from
Open

Conversation

itzzritik
Copy link

Friendly UI Reactions

This PR adds new Reactions feature to the chat window

Screenshots

@itzzritik itzzritik linked an issue Jul 19, 2021 that may be closed by this pull request
@ear-dev
Copy link

ear-dev commented Jul 28, 2021

@itzzritik this looks pretty good, but I am seeing some non-intuitive behaviors, especially when I try to change reactions to older messages.

  1. Each time I add a new reaction the UI reacts like there is a new message. I don't think we want that.
    a.) If I react to my own message, the UI will scroll immediately down to the bottom and I lose focus on the part of the conversation I was looking at.
    b.) If I react to somebody else's message, I get the bar that indicates there is a new message. If I click it, it scrolls me down to the bottom, but there is no new message.

  2. If I try to change a reaction in an older message, sometimes it works and sometimes it does not. It's kind of flaky. Sometimes I can change reactions on my own messages, but not on the others.... in fact, sometimes the long press gives me the reactions menu and sometimes it does not.

  3. If more than one user adds a reaction to the same message it just changes the reaction. On the web app it will add another reaction. Can we do that too?

Are you able to reproduce these issues? Can we fix? Thanks.

@ear-dev
Copy link

ear-dev commented Jul 28, 2021

@bhardwajaditya can you take a look at this PR please? Thanks.

@ear-dev
Copy link

ear-dev commented Aug 26, 2021

@itzzritik please make a list of TODO items related to this PR in the comments section. We will circle back to improve all of this later.

@itzzritik
Copy link
Author

TODO:

@ear-dev Chat room behaves weirdly on reacting to messages:

  1. On reacting to my Messages it scrolls to the bottom.
  2. On reacting to the recipient's message it prompts a toast to scroll to the bottom.

This issue is not introduced in this PR but has existed since before.
I've tested and didn't find this issue upstream, but I could see this issue in our version of the repository. i.e WideChat/Rocket.Chat

I recommend tracking the fix of this issue in a separate task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Reactions
2 participants