-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rework hook registration #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
top notch work, great new system! A few minor nits
common/src/test/java/net/william278/husktowns/hook/maphooks/PlanHookTests.java
Outdated
Show resolved
Hide resolved
common/src/main/java/net/william278/husktowns/hook/maphooks/BlueMapHook.java
Outdated
Show resolved
Hide resolved
common/src/main/java/net/william278/husktowns/hook/HookManager.java
Outdated
Show resolved
Hide resolved
bukkit/src/main/java/net/william278/husktowns/hook/BukkitHookManager.java
Show resolved
Hide resolved
Looks like this causes compile to fail during testing? Reflection might be breaking something here. |
i think it has to with worldguardhook, that was the issue last time |
it might be the Mockito trying to load the WG hook and going nuts for some reason. |
i havent the slightest clue as to whats going wrong, maybe some bad accessors? |
I did find that you're registering each hook twice |
WHUUTT, lemme check this |
…ctor with @PluginHook
Removed MockBukkit.unmock(): it was indefinitely checking for task finish
Bump |
Is there reviews that i cant see or am i tweaking bc i see "1 change requested" but no actual comments |
New way to register a hook: