Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPDATE: replace python-jose with pyjwt #393

Merged
merged 5 commits into from
Nov 24, 2022
Merged

Conversation

Segelzwerg
Copy link
Contributor

@Segelzwerg Segelzwerg commented Nov 14, 2022

python-jose seems unmainted.

Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg requested a review from iTitus November 14, 2022 22:48
@Segelzwerg Segelzwerg self-assigned this Nov 14, 2022
@Segelzwerg Segelzwerg added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 14, 2022
@Segelzwerg Segelzwerg changed the title UPDAET: replace python-jose with pyjwt UPDATE: replace python-jose with pyjwt Nov 14, 2022
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #393 (2d415b6) into main (7d771df) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #393      +/-   ##
==========================================
+ Coverage   96.57%   96.66%   +0.09%     
==========================================
  Files          39       39              
  Lines         963      960       -3     
==========================================
- Hits          930      928       -2     
+ Misses         33       32       -1     
Impacted Files Coverage Δ
whist_server/services/authentication.py 100.00% <100.00%> (+2.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

iTitus
iTitus previously approved these changes Nov 24, 2022
@iTitus
Copy link
Contributor

iTitus commented Nov 24, 2022

@Segelzwerg this dep also needs to be removed from core, if possible

@iTitus iTitus merged commit c3c925b into main Nov 24, 2022
@iTitus iTitus deleted the dep/python_jose_with_pyjwt branch November 24, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants