Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: user ID #372

Merged
merged 10 commits into from
Nov 8, 2022
Merged

FEATURE: user ID #372

merged 10 commits into from
Nov 8, 2022

Conversation

Segelzwerg
Copy link
Contributor

No description provided.

@Segelzwerg
ADD: user id to user
d87a9b8 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: have to getters for users
e2cc8d2 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: use name getter for authentication
a168cd7 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: test to new getters
3e1ba79 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg self-assigned this Oct 25, 2022
@Segelzwerg Segelzwerg added the enhancement New feature or request label Oct 25, 2022
@Segelzwerg Segelzwerg mentioned this pull request Oct 25, 2022
Merged
2 tasks
@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Merging #372 (715d95b) into main (fbb6eca) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #372      +/-   ##
==========================================
+ Coverage   96.63%   96.66%   +0.03%     
==========================================
  Files          39       39              
  Lines         950      959       +9     
==========================================
+ Hits          918      927       +9     
  Misses         32       32
Impacted Files Coverage Δ
whist_server/database/user.py 100.00% <100.00%> (ø)
whist_server/services/authentication.py 97.43% <100.00%> (ø)
whist_server/services/user_db_service.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Segelzwerg Segelzwerg marked this pull request as ready for review October 25, 2022 19:05
@Segelzwerg Segelzwerg requested a review from iTitus October 25, 2022 19:05
@Segelzwerg
Copy link
Contributor Author

@iTitus merge conflicts are resolved

Segelzwerg and others added 2 commits November 8, 2022 15:30
@Segelzwerg
REFORMAT
e47777e 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@iTitus
Merge branch 'main' into feature/user_id
715d95b
@iTitus iTitus merged commit 370c912 into main Nov 8, 2022
@iTitus iTitus deleted the feature/user_id branch November 8, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus iTitus approved these changes

Assignees

@Segelzwerg Segelzwerg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Segelzwerg @iTitus