Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: next trick #368

Merged
merged 17 commits into from
Nov 8, 2022
Merged

FEATURE: next trick #368

merged 17 commits into from
Nov 8, 2022

Conversation

Segelzwerg
Copy link
Contributor

No description provided.

@Segelzwerg
ADD: trick done event
6bb6c28 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: similar test
c5d75d4 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: test for next trick
a677734 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: next trick
180b211 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: test no user
aa35476 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: test player not joined
da3c21c 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: require player to join
aa1b409 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg linked an issue Oct 23, 2022 that may be closed by this pull request
BUG: error handling after last trick of hand #276
Closed
@Segelzwerg Segelzwerg self-assigned this Oct 23, 2022
@Segelzwerg Segelzwerg added bug Something isn't working enhancement New feature or request labels Oct 23, 2022
@codecov
Copy link

codecov bot commented Oct 23, 2022 •
edited
Loading

Codecov Report

Merging #368 (77ddac1) into main (68c947f) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
+ Coverage   96.54%   96.63%   +0.08%     
==========================================
  Files          39       39              
  Lines         926      950      +24     
==========================================
+ Hits          894      918      +24     
  Misses         32       32
Impacted Files Coverage Δ
whist_server/api/room/game.py 100.00% <100.00%> (ø)
whist_server/web_socket/events/event.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Segelzwerg
FIX: duplication
a279092 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: test for player requirements
b1bcbff 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: require player
c799db5 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg linked an issue Oct 23, 2022 that may be closed by this pull request
BUG: Next hand does not require user credential #367
Closed
@Segelzwerg
ADD: last trick hand test
6dc5bf5 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: last trick hand
6a06015 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
FIX: format
dee0124 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: trick not done test
d34c7f5 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg marked this pull request as ready for review October 23, 2022 16:43
@Segelzwerg Segelzwerg requested a review from iTitus October 23, 2022 16:43
@Segelzwerg Segelzwerg mentioned this pull request Oct 23, 2022
Open
3 tasks
@iTitus iTitus merged commit fbb6eca into main Nov 8, 2022
@iTitus iTitus deleted the 276-bug-error-handling-after-last-trick-of-hand branch November 8, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus iTitus approved these changes

Assignees

@Segelzwerg Segelzwerg

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: Next hand does not require user credential BUG: error handling after last trick of hand
2 participants
@Segelzwerg @iTitus