Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: invalid room ID #366

Merged
merged 2 commits into from
Oct 23, 2022
Merged

FIX: invalid room ID #366

merged 2 commits into from
Oct 23, 2022

Conversation

Segelzwerg
Copy link
Contributor

fixes #258

@Segelzwerg
ADD: test for invalid id
e18161b 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: catch invalid ID
aa9f217 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg requested a review from iTitus October 23, 2022 12:38
@Segelzwerg Segelzwerg self-assigned this Oct 23, 2022
@Segelzwerg Segelzwerg added the bug Something isn't working label Oct 23, 2022
@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #366 (aa9f217) into main (2c3906b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #366   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          39       39           
  Lines         922      926    +4     
=======================================
+ Hits          909      913    +4     
  Misses         13       13
Impacted Files Coverage Δ
whist_server/services/room_db_service.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iTitus iTitus merged commit fa15d3f into main Oct 23, 2022
@iTitus iTitus deleted the fix/invalid_room_id branch October 23, 2022 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus iTitus approved these changes

Assignees

@Segelzwerg Segelzwerg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: error handling for invalid room id
2 participants
@Segelzwerg @iTitus