Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: user info #342

Merged
merged 2 commits into from
Sep 2, 2022
Merged

FEATURE: user info #342

merged 2 commits into from
Sep 2, 2022

Conversation

Segelzwerg
Copy link
Contributor

No description provided.

@Segelzwerg
ADD: test player info
f789726 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: info route
dd3c947 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg requested a review from iTitus September 2, 2022 17:12
@Segelzwerg Segelzwerg self-assigned this Sep 2, 2022
@Segelzwerg Segelzwerg added the enhancement New feature or request label Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022 •
edited
Loading

Codecov Report

Merging #342 (dd3c947) into main (6236225) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   95.77%   95.81%   +0.04%     
==========================================
  Files          38       39       +1     
  Lines         875      884       +9     
==========================================
+ Hits          838      847       +9     
  Misses         37       37
Impacted Files Coverage Δ
whist_server/__init__.py 100.00% <100.00%> (ø)
whist_server/api/user/info.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

iTitus
iTitus reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@iTitus iTitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No wait a sec. What data is transmitted there? Something private or temporary?

@Segelzwerg Segelzwerg linked an issue Sep 2, 2022 that may be closed by this pull request
FEATURE: add user info route #260
Closed
@Segelzwerg
Copy link
Contributor Author

No wait a sec. What data is transmitted there? Something private or temporary?

Username, rating and number of games

@Segelzwerg Segelzwerg merged commit c9fac91 into main Sep 2, 2022
@Segelzwerg Segelzwerg deleted the feature/user_info branch September 2, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus iTitus approved these changes

Assignees

@Segelzwerg Segelzwerg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: add user info route
2 participants
@Segelzwerg @iTitus