Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REMOVE: DB mention in Game Info Service #334

Merged
merged 2 commits into from
Aug 28, 2022
Merged

REMOVE: DB mention in Game Info Service #334

merged 2 commits into from
Aug 28, 2022

Conversation

Segelzwerg
Copy link
Contributor

No description provided.

@Segelzwerg
REFACTOR: remove db mention in service
d9221b4 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg requested a review from iTitus August 27, 2022 10:20
@Segelzwerg Segelzwerg self-assigned this Aug 27, 2022
@Segelzwerg Segelzwerg added the python Pull requests that update Python code label Aug 27, 2022
iTitus
iTitus previously approved these changes Aug 27, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Aug 27, 2022 •
edited
Loading

Codecov Report

Merging #334 (d898bfc) into main (cc3ae8e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   95.68%   95.68%           
=======================================
  Files          36       36           
  Lines         835      835           
=======================================
  Hits          799      799           
  Misses         36       36
Impacted Files Coverage Δ
whist_server/__init__.py 100.00% <100.00%> (ø)
whist_server/api/api.py 100.00% <100.00%> (ø)
whist_server/services/game_info_service.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Segelzwerg
REMOVE: mention if error being raised
d898bfc 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg requested a review from iTitus August 27, 2022 10:22
@Segelzwerg Segelzwerg linked an issue Aug 27, 2022 that may be closed by this pull request
GameInfoDatabaseService misleading name and documentation #280
Closed
@iTitus iTitus merged commit 6a4491b into main Aug 28, 2022
@iTitus iTitus deleted the refactor/game_info_database_service branch August 28, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus iTitus approved these changes

Assignees

@Segelzwerg Segelzwerg

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GameInfoDatabaseService misleading name and documentation
2 participants
@Segelzwerg @iTitus