Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADD: python 3.11 support #103

Merged
merged 53 commits into from
Oct 25, 2022
Merged

ADD: python 3.11 support #103

merged 53 commits into from
Oct 25, 2022

Conversation

Segelzwerg
Copy link
Contributor

No description provided.

@Segelzwerg Segelzwerg added the python Pull requests that update Python code label Oct 19, 2021
@Segelzwerg Segelzwerg self-assigned this Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021 •
edited
Loading

Codecov Report

Merging #103 (482d1c9) into main (56714c3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #103   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files          39       39           
  Lines         926      926           
=======================================
  Hits          894      894           
  Misses         32       32

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@iTitus iTitus force-pushed the prepare-python-3.11 branch from ee036b0 to 0240a63 Compare July 19, 2022 21:10
Segelzwerg and others added 25 commits July 20, 2022 14:58
@Segelzwerg
ADD: 3.11 to supported versions
31b1811
@Segelzwerg
UPDATE: use mocks instead of db calls
3bff6ef 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: package import
88289c2 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
REMOVE: no longer use parameters
5d09a0c 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: use base test and mocks
e25b32b 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
ADD: hash mock
8b118e9 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: use base class and mocks
6e8e345 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: mark integration tests
2935359 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: dependency injection
1e1e820 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
WIP: migrate room db tests to mocking
bb4921b 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
REMOVE: no longer needed arguments
f3bc870 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@iTitus @Segelzwerg
try to fix github publish
f41cb03
@Segelzwerg
FIX: typo
57410e5 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
REVERT: dependency injection
3ce0874 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: use integration test for db services
dc85d76 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
REMOVE: mocks
07afaf6 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg
UPDATE: use db only in db tests
21f60f1 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@iTitus @Segelzwerg
change order of steps in ci
7422a72
@iTitus @Segelzwerg
Use context instead of file
5fdede3
@Segelzwerg
REMOVE: workflow separation try
7ccee4e 
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@iTitus @Segelzwerg
Use metadata action to generate tags
72f360a
@iTitus @Segelzwerg
Fix error in workflow file
1d1954f
@iTitus @Segelzwerg
Unify docker publish ci
368091e
@iTitus @Segelzwerg
Bump version
743b2a8
@Segelzwerg
UPDATE: use db only in int tests
b376f4b
@Segelzwerg
Copy link
Contributor Author

The problem here is tomli, which is part of the standard lib from 3.11 on.

@Segelzwerg Segelzwerg marked this pull request as ready for review October 22, 2022 20:53
@Segelzwerg Segelzwerg requested a review from iTitus October 25, 2022 11:12
iTitus
iTitus reviewed Oct 25, 2022
View reviewed changes
Copy link
Contributor

@iTitus iTitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want to wait until all packages have explicit support for 3.11?

@Segelzwerg
Copy link
Contributor Author

Don't you want to wait until all packages have explicit support for 3.11?

We could add 3.11 without making passes to it mandatory. So we offer only limited support on it.

iTitus
iTitus approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@iTitus iTitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we don't make the CI runs for 3.11 mandatory.

@iTitus iTitus merged commit 73038f8 into main Oct 25, 2022
@iTitus iTitus deleted the prepare-python-3.11 branch October 25, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iTitus iTitus iTitus approved these changes

Assignees

@Segelzwerg Segelzwerg

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Segelzwerg @iTitus