Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: next rubber #258

Merged
merged 8 commits into from
Nov 8, 2022
Merged

FEATURE: next rubber #258

merged 8 commits into from
Nov 8, 2022

Conversation

Segelzwerg
Copy link
Contributor

@Segelzwerg Segelzwerg commented Oct 26, 2022

Breaking Changes

whist_core.session.table.Table no longer expects whist_core.session.matcher.Matcherˋ during Table.start()` but during initialization.

Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>
@Segelzwerg Segelzwerg self-assigned this Oct 26, 2022
@Segelzwerg Segelzwerg added the enhancement New feature or request label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #258 (90cd96f) into main (6a10d74) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
+ Coverage   97.14%   97.19%   +0.04%     
==========================================
  Files          28       28              
  Lines         770      783      +13     
==========================================
+ Hits          748      761      +13     
  Misses         22       22              
Impacted Files Coverage Δ
whist_core/game/errors.py 100.00% <100.00%> (ø)
whist_core/session/matcher.py 100.00% <100.00%> (ø)
whist_core/session/table.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

iTitus
iTitus previously approved these changes Nov 8, 2022
Signed-off-by: Segelzwerg <25705862+Segelzwerg@users.noreply.github.com>

# Conflicts:
#	tests/whist_core/session/test_table.py
#	whist_core/session/table.py
@iTitus iTitus merged commit bec2618 into main Nov 8, 2022
@iTitus iTitus deleted the feature/next_rubber branch November 8, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants