Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patterns: Add RPM pattern #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

patterns: Add RPM pattern #350

wants to merge 1 commit into from

Conversation

k0tran
Copy link

@k0tran k0tran commented Feb 9, 2025

First attempt at implementing RPM package file format in pattern language. Would like your review and critique.

File spec: http://ftp.rpm.org/max-rpm/s1-rpm-file-format-rpm-file-format.html

Would also note that I decided not to patternize LZMA archive which is in this file too. Firstly it is an RPM and it already has a lot of patterns. Secondly LZMA should be separate pattern

@k0tran
Copy link
Author

k0tran commented Feb 9, 2025

Actually it not always LZMA + CPIO
There is tag payloadformat which states for example CPIO
There is tag payloadcompressor which states for example lzma or xz
There is also payloadflags which specify compress level
RPM Source

But it is package contents anyway so I would propose just labeling it as that

@WerWolv
Copy link
Owner

WerWolv commented Feb 16, 2025

Thanks a lot! Looks good to me.
Could you also upload a test file so the CI can run tests on your pattern?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants