Added lambert conformal projection for FV3SAR and handled composite r… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eflectivity correctly (#14)
WenMeng-NOAA
added a commit
that referenced
this pull request
Dec 13, 2021
* update modules for jet * update modules for jet (#2) * feature/HAFS: Switch back to use netcdf/3.6.3 on Jet. Can consider switching to netcdf/4.x.x for all platforms later on. * support/HAFS: Update for regular lat-lon grids to FV3 output change on coordinate (Cherry-picked from Jili.Dong's commit). * update for jet; update for new write component coordinates * add post lib for jet * update for Lambert/rotated latlon to output earth relative wind * fix ref at -10C * Add the configuration for Orion. * Update modulefiles/post/v8.0.0-jet to use modules under the lfs4 disk. * Update modulefiles/post/v8.0.0-jet. * Symbolic link from modulefiles/post/v8.0.0-cray-intel to modulefiles/post/v8.0.0-wcoss_cray. * Update compile_upp.sh so that it can be called/run from the workflow level build driver script. More specifically, the following line is changed from source detect_machine.sh into source ./detect_machine.sh * Add HAFS nosat post control files (@LinZhu-NOAA). Co-authored-by: Jili Dong <Jili.Dong@noaa.gov> Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: Wen Meng <wmeng@Orion-login-2.HPC.MsState.Edu>
WenMeng-NOAA
added a commit
that referenced
this pull request
Apr 22, 2022
* Added lambert conformal projection for FV3SAR and handled composite reflectivity correctly (NOAA-EMC#14) (#2) * exec is selectable for executable directory (NOAA-EMC#448) * Doxygen for CALGUST (NOAA-EMC#451) * Doxygen for CALDRG.f * This is part of Issue NOAA-EMC#392 Fixes the doxygen warnings in CALGUST.f Please review this subroutine. Thank you. * The fix in CALUPDHEL.f (NOAA-EMC#458) * Modify CALUPDHEL.f for restricting undefined grids in computation. * Update VERSION to 10.0.12. * Bug fix for SLLEVEL bound issue when not RUC LSM (NOAA-EMC#463) Co-authored-by: Tracy <tracy.hertneky@noaa.gov> * Doxygen caldrg caldwcp calgust refinement (NOAA-EMC#464) * Further refinement to the tables and logs. * Further refinement to the tables and logs. (NOAA-EMC#455) * This is part of Issue NOAA-EMC#392 (NOAA-EMC#460) Fixes the doxygen warnings in CALHEL.f CALHEL2.f CALHEL3.f Please review this subroutine. Thank you. * Unify global and regional FV3 read interfaces (NOAA-EMC#453) * Unify the interfaces for reading FV3 outputs in netcdf. * Remove interface INITPOST_GFS_NETCDF_PARA. * Remove INITPOST_GFS_NETCDF.f. * Remove the capability of serial netcdf reading FV3 outputs. * Correct reading rswinc. * Remove duplication in CLDRAD.f. * Remove duplicated avgalbedo reading * Add changes for reading pwat from model. * Clean up commented out code * Clean up duplicated lines * Add ability to compile script to use non-intel compilers; add Cheyenne modulefiles for gnu and intel (NOAA-EMC#468) * Add cheyenne modulefile * Intel 19 --> 2021 * Add ability to specify compiler; move all existing modulefiles to ${name}_intel since they are all for intel compilers; add "cheyenne_gnu" modulefile * Revert move of intel modulefiles; now the implicit default for a modulefile is intel, only gnu and other compilers will have the compiler name appended to the modulefile * Allow for lua modulefiles with ".lua" appended * This is part of Issue NOAA-EMC#392 (NOAA-EMC#465) Fixes the doxygen warnings in CALLCL.f CALMCVG.f CALMICT.f * This is part of Issue NOAA-EMC#392 (NOAA-EMC#466) Fixes the doxygen warnings in CALPBL.f CALPBLREGIME.f CALPOT.f CALPW.f. * Doxygen in CALRAD_WCLOUD_newcrtm.f CALRCH.f CALSTRM.f CALTAU.f CALTHTE.f CALUPDHEL.f. (NOAA-EMC#467) * This is part of Issue NOAA-EMC#392. Fixes the doxygen warnings in CALRAD_WCLOUD_newcrtm.f CALRCH.f CALSTRM.f CALTAU.f CALTHTE.f CALUPDHEL.f. * Fixed typo. * Update to PR NOAA-EMC#458. * Doxygen in CALVOR.f, CALWXT_BOURG.f, CLDRAD.f, COLLECT.f, COLLECT_LOC.f, DEALLOCATE.f, and DEALLOCATE.f (NOAA-EMC#469) * This is part of Issue NOAA-EMC#392. Fixes the doxygen warnings in CALVOR.f, CALWXT_BOURG.f, CLDRAD.f, COLLECT.f, COLLECT_LOC.f, DEALLOCATE.f, and DEALLOCATE.f. * Fixed minor bug in CALVOR.f. * Update to PR#453. * More updates. * 20220411 Bo Cui 2D decompositio CALVOR.f and INITPOST_NETCDF.f * 20220411 Bo Cui update doxgen and global and regional FV3 read interface * 20220414 Bo Cui: remove read_netcdf_2d_scatter and read_netcdf_3d_scatter from INITPOST_NETCDF.f * 20220415 Bo Cui delete CALVOR.f, add exch of gdlon in INITPOST_NETCDF.f * 20220421 Bo Cui Doxygen in UPP_PHYSICS.f,add restriction run 2D decomp only for GFS/FV3R in WRFPOST.f Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: Wen Meng <wen.meng@noaa.gov> Co-authored-by: Chan-Hoo.Jeon-NOAA <60152248+chan-hoo@users.noreply.github.com> Co-authored-by: kayeekayee <kayee.wong@noaa.gov> Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com> Co-authored-by: Tracy <tracy.hertneky@noaa.gov> Co-authored-by: Michael Kavulich <kavulich@ucar.edu>
WenMeng-NOAA
added a commit
that referenced
this pull request
Jun 10, 2022
* Changes to support 2D Decomposition shape changes. Full I dimension remains in all arrays bu t SURFCE is altered to use isx:iex bounds which are equivalent to IM which is equivalent to 1:IM * test of commit only added one comment to PROCESS.f * comment test 2 * Added more routines to 2D decomposition * Changed isx and iex to ISTA and IEND in listed routines. ISTA had prior use in MDL2P.f and that needed changing. IEND had prior use in PARA_CONFIG, changed to IENDJ in PARA_CONFIG2 where needed PARA_CONFIG did not need changing * test commit of new base into clone * repair of a bunch of changed routines somehow corrupted by a merge 5/3/2021 * fixed 5/25 problem * added ctlblk change to support ista and iend partial I dimensons * added para_range2 to PARA_RANGE.f to support 2D decomposition * Modified MPI_FIRST.f to support a 2D decomposition but the actual numbers used remain the 1D special case and the changes just add two more indices for start and end I domains and logic to convert scatter counts and displacements to the product of the I and J subdomain sizes rather than I full domain x J subdomain. * Added support for halo settings of 2D boundaries i.e ista_2l to match the 1D analogs long present in the source 6/1/2021 * Added definitions for ista_2u, and ista_2u in MPI_FIRST.f * Reshaped arrays in MDL2FLD.f to support 2D decomposition. Modified TWO (only) loops to try thie * Remove TIMEF.f. * 20210702 JesseMeng modify MPI_FIRST.f MDLFLD.f for 2D decomposition * 20210706 BoCui modify INITPOST_GFS_NETCDF_PARA.f * 20210707 JesseMeng modified grib2_module.f for 2d decomposition * test version INITPOST_GFS_NETCDF_PARA.f * test version INITPOST_GFS_NETCDF_PARA.f and MPI_FIRST.f * 20210713 BoCui test INITPOST_GFS_NETCDF_PARA.f, MPI_FIRST.f and ALLOCATE_ALL.f * 20210713 BoCui test INITPOST_GFS_NETCDF_PARA.f, MPI_FIRST.f and ALLOCATE_ALL.f * 20210719 BoCui Modified CLDRAD.f for 2d decomposition * 20210816 Jesse Meng commit George's EXCH update for 1 layer 2D halos transforming * 20210816 Jesse Meng remove ifcore in EXCH * 20210903 Bo Cui update ALLOCATE_ALL.f after new merge from 'upstream/develop' * 20210903 Bo Cui Added new routines to 2D decomposition * 20210903 Jesse Meng fixed the ieql allocation bug in ALLOCATE_ALL.f * 20210904 Bo Cui fixed CLDRAD.f * 20210913 Jesse Meng commit progress of 2D decomposition * 20210917 Bo Cui add new routines to 2D decomposition * 20210917 Jesse Meng remove 4 legacy files * 20210917 Jesse Meng remove legacy code SLP_NMM EXCH2 * 20210917 Jesse Meng remove legacy code INITPOST_GFS_SIGIO.f INITPOST_GFS_NEMS.f * 20210917 Jesse Meng add INITPOST_GFS_NEMS.f back to avoid compiling error. * 20210930 Jesse Meng add George's itag/numx entry and progress on 2D decompose * 20211015 Jesse Meng progress on 2D DECOMPOSITION * 20211017 Bo Cui add new subroutines to UPP 2D decomposition * 20211026 Jesse Meng commit progress in 2D DECOMPOSITION * 20211026 Jesse Meng fix INITPOST_GFS_NETCDF_PARA.f for 2D DECOMPOSITION * 20211026 Jesse Meng update SURFCE.f for 2D DECOMPOSITION * 20211103 Jesse Meng commit progress of 2D DECOMPOSITION * 20211106 Bo Cui commit progress of 2D decomposition * 20211109 Jesse Meng updates for 2D DECOMPOSITION * 20211110 Jesse Meng updates in 2D DECOMPOSITION * 20211112 Jesse Meng updates for 2D DECOMPOSITION * 20211115 Jesse Meng updates for 2D DECOMPOSITION * 20211119 Jesse Meng updates for 2D DECOMPOSITION * 20211201 Jesse Meng move CALVOR to UPP_PHYSICS module; implement fullpole in MPI_FIRST * 20211202 Jesse Meng minor update of MPI_FIRST using mpi_allgatherv * 20211203 Jesse Meng implement fullpole in MDL2THANDPV and CALDIV * 20211207 Jesse Meng update MISCLN.f SURFCE.f * 20211208 Jesse Meng add parm/hafs_nosat files * 20211213 Bo Cui updates for 2D decomposition * 20211213 Jesse Meng update the merged 'upstream/develop' and 'post_2d_decomp' branch to 2d_decomp style * 20211215 Jesse Meng use i=0:im+1 for GFS in MPI_FIRST and EXCH * 20211216 Jesse Meng minor update UPP_PHYSICS for i=0:im+1 expansion * 20220104 Jesse Meng add George's minor fix in EXHC.f * 20220118 Jesse Meng commit George's cleaned up code. * 20220203 Jesse Meng - update MAPSSLP.f to be consistent with develop branch. * 20220222 Jesse Meng add checkcoords flag in EXCH.f to move around George's debug code. * 20220302 Jesse Meng Restrict computation from undefined grids * 20220304 Bo Cui Add a reset of numx=1 if remainder of num_procs/numx is not 0 * 20220310 Jesse Meng Add a reset of numx=1 if(numx>num_procs/2) * 20220322 Jesse Meng mpi_allgatherv change communicator to MPI_COMM_COMP * 20220328 Jesse Meng bug fix for passing 2d subarrays between subroutines * 20220328 Jesse Meng minor fix for CLDRAD call BOUND variable array size * 20220330 Jesse Meng fix cloud cover variabes full field collection in 2d decomp * 20220401 Jesse Meng minor fix for CALMCVG.f and update CALUPDHEL.f with develop * 20220414 BoCui sync and merge UPP/develop into post_2d_decomp (#7) * Added lambert conformal projection for FV3SAR and handled composite reflectivity correctly (NOAA-EMC#14) (#2) * exec is selectable for executable directory (NOAA-EMC#448) * Doxygen for CALGUST (NOAA-EMC#451) * Doxygen for CALDRG.f * This is part of Issue NOAA-EMC#392 Fixes the doxygen warnings in CALGUST.f Please review this subroutine. Thank you. * The fix in CALUPDHEL.f (NOAA-EMC#458) * Modify CALUPDHEL.f for restricting undefined grids in computation. * Update VERSION to 10.0.12. * Bug fix for SLLEVEL bound issue when not RUC LSM (NOAA-EMC#463) Co-authored-by: Tracy <tracy.hertneky@noaa.gov> * Doxygen caldrg caldwcp calgust refinement (NOAA-EMC#464) * Further refinement to the tables and logs. * Further refinement to the tables and logs. (NOAA-EMC#455) * This is part of Issue NOAA-EMC#392 (NOAA-EMC#460) Fixes the doxygen warnings in CALHEL.f CALHEL2.f CALHEL3.f Please review this subroutine. Thank you. * Unify global and regional FV3 read interfaces (NOAA-EMC#453) * Unify the interfaces for reading FV3 outputs in netcdf. * Remove interface INITPOST_GFS_NETCDF_PARA. * Remove INITPOST_GFS_NETCDF.f. * Remove the capability of serial netcdf reading FV3 outputs. * Correct reading rswinc. * Remove duplication in CLDRAD.f. * Remove duplicated avgalbedo reading * Add changes for reading pwat from model. * Clean up commented out code * Clean up duplicated lines * Add ability to compile script to use non-intel compilers; add Cheyenne modulefiles for gnu and intel (NOAA-EMC#468) * Add cheyenne modulefile * Intel 19 --> 2021 * Add ability to specify compiler; move all existing modulefiles to ${name}_intel since they are all for intel compilers; add "cheyenne_gnu" modulefile * Revert move of intel modulefiles; now the implicit default for a modulefile is intel, only gnu and other compilers will have the compiler name appended to the modulefile * Allow for lua modulefiles with ".lua" appended * This is part of Issue NOAA-EMC#392 (NOAA-EMC#465) Fixes the doxygen warnings in CALLCL.f CALMCVG.f CALMICT.f * This is part of Issue NOAA-EMC#392 (NOAA-EMC#466) Fixes the doxygen warnings in CALPBL.f CALPBLREGIME.f CALPOT.f CALPW.f. * Doxygen in CALRAD_WCLOUD_newcrtm.f CALRCH.f CALSTRM.f CALTAU.f CALTHTE.f CALUPDHEL.f. (NOAA-EMC#467) * This is part of Issue NOAA-EMC#392. Fixes the doxygen warnings in CALRAD_WCLOUD_newcrtm.f CALRCH.f CALSTRM.f CALTAU.f CALTHTE.f CALUPDHEL.f. * Fixed typo. * Update to PR NOAA-EMC#458. * Doxygen in CALVOR.f, CALWXT_BOURG.f, CLDRAD.f, COLLECT.f, COLLECT_LOC.f, DEALLOCATE.f, and DEALLOCATE.f (NOAA-EMC#469) * This is part of Issue NOAA-EMC#392. Fixes the doxygen warnings in CALVOR.f, CALWXT_BOURG.f, CLDRAD.f, COLLECT.f, COLLECT_LOC.f, DEALLOCATE.f, and DEALLOCATE.f. * Fixed minor bug in CALVOR.f. * Update to PR#453. * More updates. * 20220411 Bo Cui 2D decompositio CALVOR.f and INITPOST_NETCDF.f * 20220411 Bo Cui update doxgen and global and regional FV3 read interface * 20220414 Bo Cui: remove read_netcdf_2d_scatter and read_netcdf_3d_scatter from INITPOST_NETCDF.f * 20220415 Bo Cui delete CALVOR.f, add exch of gdlon in INITPOST_NETCDF.f * 20220421 Bo Cui Doxygen in UPP_PHYSICS.f,add restriction run 2D decomp only for GFS/FV3R in WRFPOST.f Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: Wen Meng <wen.meng@noaa.gov> Co-authored-by: Chan-Hoo.Jeon-NOAA <60152248+chan-hoo@users.noreply.github.com> Co-authored-by: kayeekayee <kayee.wong@noaa.gov> Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com> Co-authored-by: Tracy <tracy.hertneky@noaa.gov> Co-authored-by: Michael Kavulich <kavulich@ucar.edu> * 20220502 Bo Cui code cleanup * 20220512 Jesse Meng minor fix for INITPOST_GFS_NEMS_MPIIO.f calling EXCH * 20220525 Jesse Meng minor fix to 2d_decomp syntax * Update VERSION to 11.0.0 * 20220607 Jesse Meng add variable declaration block in PARA_RANGE.f * 20220608 Jesse Meng remove blank spaces in sorc/ncep_post.fd/AllGETHERV_GSD.f * Add 2D decomp overview documentation (#6) * Add 2D decomp overview documentation * Update 2D overview Co-authored-by: George Vandenberghe <George.Vandenberghe@noaa.gov> Co-authored-by: wx15gv <George.Vandenberghe@v71a1.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@m71a1.ncep.noaa.gov> Co-authored-by: Bo Cui <Bo.Cui@noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@m71a2.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@m72a1.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@m71a3.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@v71a1.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@v72a1.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@v71a3.ncep.noaa.gov> Co-authored-by: wx22mj <Jesse.Meng@v71a2.ncep.noaa.gov> Co-authored-by: Jesse.Meng <Jesse.Meng@noaa.gov> Co-authored-by: BoCui-NOAA <53531984+BoCui-NOAA@users.noreply.github.com> Co-authored-by: Chan-Hoo.Jeon-NOAA <60152248+chan-hoo@users.noreply.github.com> Co-authored-by: kayeekayee <kayee.wong@noaa.gov> Co-authored-by: Tracy Hertneky <39317287+hertneky@users.noreply.github.com> Co-authored-by: Tracy <tracy.hertneky@noaa.gov> Co-authored-by: Michael Kavulich <kavulich@ucar.edu> Co-authored-by: Jesse Meng <jmeng@Orion-login-4.HPC.MsState.Edu> Co-authored-by: Kate Fossell <fossell@ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eflectivity correctly (NOAA-EMC#14)