Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sonarcloud properties indepenent of fork. #87

Merged
merged 4 commits into from
Jun 7, 2022

Conversation

jorgensd
Copy link
Member

@jorgensd jorgensd commented Jun 6, 2022

Instead of having the projectKey and organization hardcoded in sonar-project.properties they should be set as repository secrets, such that it could work for both our forks without having to change back and forth in the actual code.

@jorgensd jorgensd requested a review from SarahRo June 6, 2022 16:10
@SarahRo SarahRo merged commit 27c93ec into Wells-Group:main Jun 7, 2022
@jorgensd jorgensd deleted the dokken/sonar_fixes branch June 7, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants